Skip to content

Data race on mqicb/cbMap #148

@ravellan

Description

@ravellan

It is not unlikely to use callback related verbs from multiple go routines, and since cbMap is global in the package and concurrent map access can be unsafe, perhaps it should be protected by a mutex?
POC code:

package main

import (
        "github.com/ibm-messaging/mq-golang/v5/ibmmq"
)

func main() {
        for i := 0; i < 5; i++ {
                go func() {
                        qMgr, err := ibmmq.Conn("")
                        if err != nil {
                                panic(err)
                        }
                        od := ibmmq.NewMQOD()
                        od.ObjectName = "SYSTEM.DEFAULT.MODEL.QUEUE"
                        od.ObjectType = ibmmq.MQOT_Q
                        q, _ := qMgr.Open(od, ibmmq.MQOO_INPUT_SHARED)
                        cbd := ibmmq.NewMQCBD()
                        cbd.CallbackFunction = func(a *ibmmq.MQQueueManager,
                                b *ibmmq.MQObject, c *ibmmq.MQMD, d *ibmmq.MQGMO,
                                e []byte, f *ibmmq.MQCBC, g *ibmmq.MQReturn) {
                        }
                        q.CB(ibmmq.MQOP_REGISTER, cbd, ibmmq.NewMQMD(), ibmmq.NewMQGMO())
                        qMgr.Ctl(ibmmq.MQOP_START, ibmmq.NewMQCTLO())
                        qMgr.Ctl(ibmmq.MQOP_STOP, ibmmq.NewMQCTLO())
                        q.Close(0)
                        qMgr.Disc()
                }()
        }
}

>go run -race .
==================
WARNING: DATA RACE

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions