Implemented PCIe Topology page #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiwari-nishant
commented
Nov 27, 2024
tiwari-nishant
commented
- PCIe Topology Page Vue2 to Vue3
- Jira Story: https://jsw.ibm.com/browse/PFEBMC-2371
tiwari-nishant
force-pushed
the
pcie_topology
branch
2 times, most recently
from
9da5f31 to
15e5f74
Compare
Nikhil-Ashoka
requested review from
Nikhil-Ashoka,
nabilpandiyalayil and
vedangimittal
tiwari-nishant
force-pushed
the
pcie_topology
branch
from
15e5f74 to
205c0de
Compare
tiwari-nishant
force-pushed
the
pcie_topology
branch
from
205c0de to
08d5cac
Compare
| safeModeGetter: (state) => state.safeMode, | ||
| serverStatusGetter: (state) => state.serverStatus, | ||
| isServiceUser: (state) => | ||
| state.currentUser?.RoleId === 'OemIBMServiceAgent' || !state.currentUser, |
There was a problem hiding this comment.
state currentUser is neither initialised nor assigned a value anywhere in the file. getCurrentUser() and getAccountService() functions need to be included from older file. Or directly state userPrivilege can be used as well to get the role id of the user.
nabilpandiyalayil
suggested changes
Dec 5, 2024
| return globalStore.isInPhypStandby; | ||
| }); | ||
| const isServiceUser = computed(() => { | ||
| return globalStore.isServiceUser; |
There was a problem hiding this comment.
This is returning as true for all users(eg: admin)
| function resetConfirm() { | ||
| confirm.value = false; | ||
| v$.value.$reset() | ||
| emitUpdate('update:openResetModal',false) |
There was a problem hiding this comment.
Are we using these emits anywhere?
There was a problem hiding this comment.
yes the root component PCIeToppology uses it to get the updated value
tiwari-nishant
force-pushed
the
pcie_topology
branch
2 times, most recently
from
01a9938 to
2d59a4c
Compare
* PCIe Topology Page Vue2 to Vue3 * Jira Story: https://jsw.ibm.com/browse/PFEBMC-2371
tiwari-nishant
force-pushed
the
pcie_topology
branch
from
2d59a4c to
a9e97c6
Compare
nabilpandiyalayil
approved these changes
Dec 6, 2024
vedangimittal
approved these changes
Dec 6, 2024
rfrandse
pushed a commit
that referenced
this pull request
Dec 6, 2024
* PCIe Topology Page Vue2 to Vue3 * Jira Story: https://jsw.ibm.com/browse/PFEBMC-2371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.