Skip to content

Add overwrite option to prepare #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2022
Merged

Add overwrite option to prepare #3

merged 2 commits into from
Jul 21, 2022

Conversation

SamProkopchuk
Copy link
Contributor

skillsnetwork.prepare function now has
overwrite=False kwarg which can be changed to overwrite if desired.

Also stacktraces shortened.

@SamProkopchuk SamProkopchuk requested a review from reevejd July 21, 2022 17:23
reevejd
reevejd approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@reevejd reevejd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@reevejd reevejd merged commit 9ff3490 into main Jul 21, 2022
@reevejd reevejd deleted the prepare_overwrite branch July 21, 2022 18:47
@SamProkopchuk SamProkopchuk restored the prepare_overwrite branch July 21, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reevejd reevejd reevejd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamProkopchuk @reevejd