-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/commander #81
Merged
Merged
feat/commander #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assorted bug fixes and refactors as well
jharvey10
requested review from
francinelucca
and removed request for
a team
September 14, 2023 04:55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! just a few small Qs
src/test/scopes/npm/__snapshots__/installing-packages-provider.e2e.test.ts.snap
Outdated
Show resolved
Hide resolved
Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
This was referenced Sep 21, 2023
francinelucca
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Add commander for CLI invocation * Add logic to invoke scopes based on config file * Start adding anonymization logic
francinelucca
added a commit
that referenced
this pull request
Oct 4, 2023
* wip: wip * wip: wip * feat(core): first pass at full end-to-end invocation assorted bug fixes and refactors as well * fix: validate presence of dependency key in npm scope * test: add edge case to getProjectRoot test * wip: wip * fix: rebase * feat(core): first pass at full end-to-end invocation assorted bug fixes and refactors as well * fix: validate presence of dependency key in npm scope * test: add edge case to getProjectRoot test * feat: end-to-end run logic (feat/commander) (#81) * Add commander for CLI invocation * Add logic to invoke scopes based on config file * Start adding anonymization logic * ci: remove token from release-please.yml * fix: replace carbon-design-system org with ibm-telemetrics (#86) * Update CODEOWNERS * fix: replace carbon-design-system org with ibm-telemetrics * fix: replace carbon-design-system org with ibm-telemetrics --------- Co-authored-by: Joe Harvey <51208233+jdharvey-ibm@users.noreply.github.com> * release(main): release 0.2.0 (#88) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix(deps): update node module minor versions * fix(deps): upgrade dependency eslint-plugin-vitest to ^0.3.1 (#79) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: rename empty scope exception * Update src/main/exceptions/empty-scope.error.ts Co-authored-by: Joe Harvey <51208233+jdharvey-ibm@users.noreply.github.com> --------- Co-authored-by: Joseph D. Harvey <jdharvey@us.ibm.com> Co-authored-by: Joe Harvey <51208233+jdharvey-ibm@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72
Closes #71
Closes #59
Closes #58
Closes #38