Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bashism in src/tests/runtest #2126

Closed
changwoo opened this issue Sep 2, 2019 · 3 comments
Closed

bashism in src/tests/runtest #2126

changwoo opened this issue Sep 2, 2019 · 3 comments

Comments

@changwoo
Copy link

changwoo commented Sep 2, 2019

Hello,

The src/tests/runtest script has pushd and popd but they are bash only. I think using bash is OK, but please use /bin/bash instead of /bin/sh. In some systems like Debian /bin/sh is not bash.

#!/bin/sh

pushd $tstdir

popd

@fujiwarat
Copy link
Member

fujiwarat commented Sep 5, 2019

I'd like to use Posix SH but not GNU bash but Fedora uses BASH as SH unfortunately and I'd fix the problems upon the request.

Des the following fix works for you?
fujiwarat@f39cde7

@changwoo
Copy link
Author

changwoo commented Sep 5, 2019

Des the following fix works for you?
fujiwarat@f39cde7

Yes it works! 👍

fujiwarat added a commit that referenced this issue Sep 6, 2019
@fujiwarat
Copy link
Member

Thank you for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants