Skip to content

Update nodejs.yml #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2020
Merged

Update nodejs.yml #197

merged 2 commits into from
Oct 24, 2020

Conversation

erfanium
Copy link
Collaborator

No description provided.

@erfanium erfanium requested a review from icebob October 23, 2020 11:27
@coveralls
Copy link

coveralls commented Oct 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 99.588% when pulling f480d23 on node-15-ci into e9989e0 on master.

icebob
icebob requested changes Oct 24, 2020
View reviewed changes
Copy link
Owner

@icebob icebob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the 14 because it will be the LTS, not the 15.

@erfanium erfanium requested a review from icebob October 24, 2020 15:22
@icebob icebob merged commit 0f5d43e into master Oct 24, 2020
@icebob icebob deleted the node-15-ci branch October 24, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erfanium @coveralls @icebob