Color Enhancements #200

clarkmoody · 2020-02-21T22:46:21Z

A few enhancements to the color functionality. Adds the palette feature flag that adds dependency and tie-in to the palette color management library.

Might wait for a significant change in palette to land before proceeding.

Color

Validation of RGBA values. Limit to [0,1]
Inversion
Convert to/from palette's Srgba type

Example App

Simple example app that dynamically generates a color palette based on your input color

hecrj

Thanks for looking into this! I shared some of my thoughts. Let me know what you think.

core/src/color.rs

manokara · 2020-03-31T22:28:38Z

Wouldn't palette make more sense for the feature flag since it just enables color conversions through the library? I think naming it colors gives off the idea that color management in general is optional.

clarkmoody · 2020-03-31T22:37:15Z

@manokara Renamed in 2e463fe

core/src/color.rs

Ogeon · 2020-04-05T12:08:57Z

Hey! I noticed the mentioning of my PR and just want to drop by and say that it's already possible to have conversion automatically derived in version 0.5. That includes two way conversion and From and Into. Just have a look at FromColor and IntoColor. The third example, with CssRgb, should be close to your use case.

The changes in 0.6 will make that feature more flexible, remove derived From and Into because of incompatibility, and also add automatic clamping after converting. Not to mention unlocking future improvements. But this only matters if you would implement FromColor and IntoColor. Otherwise you don't have to worry about it or wait for 0.6. 🙂

It's cool to see Palette being integrated like this and Iced is a really interesting project! Let me know if you have any questions or requests for how to make things smoother. 😁

clarkmoody · 2020-04-21T19:15:17Z

Ready for review here

hecrj

This is looking great! The example is really cool.

I have shared some ideas to improve the code here and there. We are close to merging this!

core/src/color.rs

core/src/lib.rs

examples/color_palette/Cargo.toml

examples/color_palette/src/main.rs

Sliders for many color spaces update as any other sliders are moved around. Color is space is clamped to sRGB, so Lab and Lch color spaces cannot be fully expressed. TODO: - Real-time manipulation of base color to create a color scheme. - Show slider value under each slider - Show output values in text boxes for each color space

Each color type implements ColorSpace to define its own representation and update methods. View sliders are implemented on the ColorPicker struct.

We can use `ColorSpace::new` instead

clarkmoody · 2020-05-02T18:36:40Z

Very cool changes @hecrj!

`Point` and `Size` are now properly re-exported.

hecrj

Awesome!

As many different colors do not play well with GIF compression, I have added a static screenshot instead of an animated GIF in the example README. The image links to an animated Gfycat, like most of the other examples.

I think this ship is ready to sail! Thank you for all the work and the great example :D

clarkmoody · 2020-05-04T22:02:15Z

Aww yeah

hecrj reviewed Feb 22, 2020

View reviewed changes

core/src/color.rs Outdated Show resolved Hide resolved

core/src/color.rs Show resolved Hide resolved

core/src/color.rs Show resolved Hide resolved

clarkmoody force-pushed the color-enhancements branch from 2b0d9f0 to 2869ff5 Compare March 31, 2020 21:07

hecrj reviewed Apr 1, 2020

View reviewed changes

core/src/color.rs Outdated Show resolved Hide resolved

hecrj reviewed Apr 1, 2020

View reviewed changes

core/src/color.rs Outdated Show resolved Hide resolved

hecrj added feature New feature or request improvement An internal improvement labels Apr 2, 2020

clarkmoody force-pushed the color-enhancements branch from 42697e3 to 998c825 Compare April 3, 2020 22:15

clarkmoody force-pushed the color-enhancements branch from 681fc78 to 786823d Compare April 10, 2020 20:06

clarkmoody force-pushed the color-enhancements branch from 786823d to 861d6db Compare April 21, 2020 19:09

clarkmoody marked this pull request as ready for review April 21, 2020 19:14

hecrj requested changes Apr 23, 2020

View reviewed changes

hecrj added this to the 0.2.0 milestone Apr 23, 2020

clarkmoody added 14 commits April 24, 2020 15:13

Add check_rgba fn to clamp float values to [0,1]

62fddce

Add inversion functions, rename check_rgba -> new

27a4cbc

HSLColor struct, with conversions to/from RGB

0ff3cbf

Add palette dependency behind "colors" feature flag

63933e2

Conversion to palette's Srgba type

831a07f

Remove HSLColor

4009f0c

Revert from_rgb to const

bb44398

Fix docstring typo

fd484c7

Use debug assertions instead of clamp

9a4ad3d

Add const from_rgba, for RGBA initialization

e926e43

Feature name colors -> palette

7b15e4b

Add palette test for Color <-> Srgba & manipulation

408e9e5

Remove redundant from_srgba and into_srgba methods

a95d494

Simplify range declaration

56ce01e

clarkmoody added 11 commits April 24, 2020 15:13

Derive Default for Color

ea3b7b5

Conversion traits for palette::Srgb

04be010

Conditional re-export of palette from iced_core

71657b5

Use canvas to draw color palette for example

6b18e78

More theme colors and gradient of lightness

b1328f1

TextInput fields with color encodings. Draw shades.

39fd8ad

Hex label text alignment

4b90241

Do not re-export Palette from iced_core

27fadad

Replace text input fields for simple text

758a444

Use Path::rectangle and Size for drawing swatches

3e71eae

clarkmoody force-pushed the color-enhancements branch from 861d6db to 3e71eae Compare April 24, 2020 20:41

clarkmoody and others added 7 commits April 27, 2020 16:25

Abstract into ColorPicker and ColorSpace trait

430f78a

Each color type implements ColorSpace to define its own representation and update methods. View sliders are implemented on the ColorPicker struct.

Remove update_component in color_palette

11e4039

We can use `ColorSpace::new` instead

Improve generate_theme in color_palette

0a011f9

Introduce Theme type in color_palette example

4d724a8

Move application implementation in color_palette

555371f

Use Path::rectangle directly in color_palette

573929d

Reuse triangle path with transforms in color_palette

03ca7ee

hecrj added 4 commits May 4, 2020 22:50

Mention color_palette in examples README

24574b3

Add screenshot of color_palette example

1a8d253

Add screenshot to README of color_palette

3d3e51a

Use only iced dependency for color_palette

e355517

`Point` and `Size` are now properly re-exported.

hecrj approved these changes May 4, 2020

View reviewed changes

Improve minor documentation details in Color

c0fd5de

hecrj merged commit 27aad74 into iced-rs:master May 4, 2020

clarkmoody deleted the color-enhancements branch May 4, 2020 22:02

hecrj mentioned this pull request Nov 26, 2020

Release 0.2 — Canvas interactivity, overlay support, a renderer alternative, and more! #637

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Color Enhancements #200

Color Enhancements #200

clarkmoody commented Feb 21, 2020 •

edited

Loading

hecrj left a comment •

edited

Loading

manokara commented Mar 31, 2020

clarkmoody commented Mar 31, 2020

Ogeon commented Apr 5, 2020

clarkmoody commented Apr 21, 2020

hecrj left a comment

clarkmoody commented May 2, 2020

hecrj left a comment

clarkmoody commented May 4, 2020

Color Enhancements #200

Color Enhancements #200

Conversation

clarkmoody commented Feb 21, 2020 • edited Loading

Color

Example App

hecrj left a comment • edited Loading

Choose a reason for hiding this comment

manokara commented Mar 31, 2020

clarkmoody commented Mar 31, 2020

Ogeon commented Apr 5, 2020

clarkmoody commented Apr 21, 2020

hecrj left a comment

Choose a reason for hiding this comment

clarkmoody commented May 2, 2020

hecrj left a comment

Choose a reason for hiding this comment

clarkmoody commented May 4, 2020

clarkmoody commented Feb 21, 2020 •

edited

Loading

hecrj left a comment •

edited

Loading