fix: unable to match assets when filename contains special characters #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icelam
force-pushed
the
issue-353-special-characters
branch
from
a773315 to
ab830c1
Compare
icelam
force-pushed
the
issue-353-special-characters
branch
from
ab830c1 to
ce6be9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to fix issue #353 where the plugin fails to handle file name with special characters like
@.The root cause of the issue is that filename extracted from tag
srcattribute is a URI encoded string (e.g. 'index%40production.js'), so this PR aims to solve it by adding a decoding step when accessing theassetsobject from webpack.How has this been tested?
@in the filename is added. This is check and run to make sure the output files are properly inlined.Types of changes
featfixrefactortestRemarks
N/A