Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UIDMODE command #190

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Add UIDMODE command #190

merged 2 commits into from
Jan 23, 2021

Conversation

ca1e
Copy link
Contributor

@ca1e ca1e commented Jan 21, 2021

Add UIDMODE command to chang magic uid mode

@iceman1001
Copy link
Owner

Thank you for your contribution to the code.
I see that you have mixed up several different changes in one PR.
May I suggest you divide it up into several different PR targeted to specific changes. Like one for UIDMODE, one for NTAG etc.

@ca1e
Copy link
Contributor Author

ca1e commented Jan 21, 2021

yes and sure.I can merge the UIDMODE change only,and rebase the ntag215 support for a new PR.

@ca1e
Copy link
Contributor Author

ca1e commented Jan 22, 2021

Hi iceman, I just divide it up into different PR and have tested to be sure there is no any conflicts to merge both.thank you!
I'd like to contribute to it and try my best

@iceman1001
Copy link
Owner

Thanks, the main reason for asking is to find easily which PR that introduced a certain functionality or change.
When things changes multiple things at once, its becomes harder to find potential bugs / errors.

@ca1e ca1e changed the title contribute to RevE-rebooted Add UIDMODE command Jan 23, 2021
@iceman1001 iceman1001 merged commit 18007ef into iceman1001:master Jan 23, 2021
@iceman1001
Copy link
Owner

nice and easy to follow.
The question now since you enabled it by default, if the firmware gets too large. We were on the border before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants