Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of buttons and checkboxes used for pagination #257

Closed
mcmxcdev opened this issue Apr 18, 2023 · 2 comments
Closed
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@mcmxcdev
Copy link

Is your feature request related to a problem? Please describe.

Microsoft Edge has handy accessibility checks built-in and they detected these issues:
image

Describe the solution you'd like
Back/Forward buttons for switching pages needs to have e.g. aria-label or title attribute set: https://dequeuniversity.com/rules/axe/4.4/button-name?application=axeAPI

Checkboxes for records selection feature need to have a label, e.g. aria-label attribute since we don't want a visible label here: https://dequeuniversity.com/rules/axe/4.4/label?application=axeAPI

Describe alternatives you've considered
Ignore a11y, but it hurts the ecosystem

@icflorescu
Copy link
Owner

Thank you for raising this.

This should be fixed in a few minutes, as soon as v2.4.3 hits the npm registry.
There are a few properties you can use to override the defaults:

  • allRecordsSelectionCheckboxProps
  • getRecordSelectionCheckboxProps
  • getPaginationControlProps

I've also updated these examples in the docs website accordingly:

@icflorescu icflorescu self-assigned this Apr 18, 2023
@icflorescu icflorescu added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Apr 18, 2023
@mcmxcdev
Copy link
Author

Cool, that was very quick, thank you! Great to see some overridable defaults set, good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants