Window cropping is off on OS X

[raine]

Example frame:

Perhaps has something to do with having a retina display?

[icholy]

Hey, the osx stuff was contributed. But I'm guessing it has something to do with this line

ttygif/ttygif_osx.c

Line 125 in 7891048

if (sprintf(cmd, "convert %05d_%d.png -background white -quiet -flatten +matte -crop +0+22 -crop +4+0 -crop -4-0 +repage %05d_%d.png", index, delay, index, delay) < 0) {

[DiegoRBaquero]

Yes, it has to do with retina (2x pixels). Run the recording in a non-retina display.

[mscottnelson]

Also an issue when using eg iTerm2 where the crop size does not match Apple window frame anyway. And, further, if the terminal session exists within a window that contains more than just the single session (for example, a multi-tab session), then the cropping will also fail.

To fix properly, will probably need to make the crop dimensions of the line mentioned by @icholy dependent on the amount of visible characters. This will be terminal emulator specific. Could grab total window height with something like osascript -so -e 'tell app \"%s\" to bounds of current window' | awk 'print {$4-$2}' and compare with number of visible rows for the session, eg tput lines, tput cols or stty size. However, I'm not sure how to go about retrieving the pixel size of the emulated character (even for specifically within iTerm2) to perform the conversion that would calculate the appropriate amount of cropping.

[gpakosz]

I believe all Macs are have retina displays by now