refactor logging to include the time

[ben-jones]

No description provided.

[gsathya]

Not sure about this. Leaking PII maybe? (if we want to send logs back. otherwise fine with me)

[ben-jones]

hmm. That's true, but it can be hard to determine what is happening if the logs don't include a timestamp. Also, timing in the logs will be dependent upon the scheduling server, so I'm unsure what additional info this would leak. @gsathya, thoughts?

[gsathya]

This is as easy as changing the log format to "%(asctime)s: %(levelname)s: %(message)s"

[gsathya]

I vote for including this and not sending back logs at all. I dislike the idea of sending back logs without user action.

[ben-jones]

@gsathya, I know. I already added this for the vpn stuff. I just wanted to get people's thoughts on the change.

[ben-jones]

@gsathya, why don't we make a separate command line arg for syncing logs so that users have the ability to send logs back, but we don't enable it by default. This may make some troubleshooting easier, but I am also ok with forcing users to copy the logs into an email or something.

[gsathya]

@gsathya, why don't we make a separate command line arg for syncing logs so that users have the ability to send logs back, but we don't enable it by default.

I have strong feelings against this.

This may make some troubleshooting easier, but I am also ok with forcing users to copy the logs into an email or something.

This is the way to go.

[ben-jones]

@gsathya, then I think this is the issue for you. Let's expand the issue to include adding time stamps, creating a wiki page for users to copy and submit their logs, and removing all of the log submission functionality.

[gsathya]

Let's expand the issue to include adding time stamps,

#34

and removing all of the log submission functionality.

iclab/centinel-server#1

[gsathya]

The PRs in #33 (comment) fix the issue. Closing the ticket.

[ben-jones]

@gsatha, we also need to add a wiki page describing to users how to submit logs. Do you want a separate issue for that for should that be this issue?=

[gsathya]

Do we need this now? I'd rather have them create issues on GitHub

[gsathya]

we also need to add a wiki page describing to users how to submit logs. Do you want a separate issue for that for should that be this issue?=

https://github.com/iclab/centinel/wiki/FAQ#faq

[ben-jones]

@gsathya, seems fine.