Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Sketchbook and popup #587

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Fixes for Sketchbook and popup #587

merged 5 commits into from
Dec 7, 2023

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Dec 6, 2023

Various fixes:

  1. Deleting sketches
  2. Renaming keyboard positioning
  3. Hide the poly button

@mikeage mikeage added the bugfix Something has been fixed label Dec 6, 2023
@andybak andybak marked this pull request as ready for review December 6, 2023 23:29
mikeage
mikeage approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Code" looks sensible, didn't test

@andybak
Copy link
Contributor Author

andybak commented Dec 7, 2023

"Code" looks sensible, didn't test

I did. It appears to have fixed the issue Mike reported so I'll merge this and continue testing UI stuff.

@andybak andybak merged commit b9d2534 into main Dec 7, 2023
32 checks passed
@mikeskydev mikeskydev deleted the fix/sketchbook-popup branch December 7, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeage mikeage mikeage approved these changes

@mikeskydev mikeskydev Awaiting requested review from mikeskydev

Assignees
No one assigned
Labels
bugfix Something has been fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybak @mikeage