decompile fails when referencing ef core 5

[kellcomnet2]

Steps to reproduce

1. .net5-windows console app
2. When using the Nuget package, attempting to decompile the dll fails if I reference Microsoft.EntityFrameworkCore.Design v5.0.0

Error message shown

2020-11-26 08:41:50.9478|1 |ERROR|JobLogic.ProcessIso|Error in ProcessIso: '*************'. Error decompiling @06000004 ININ.WebServices.Core.HeaderUtilities.ApplyHeadersToRequest
2020-11-26 08:41:50.9760|1 |ERROR|JobLogic.ProcessIso|   at ICSharpCode.Decompiler.CSharp.CSharpDecompiler.DecompileBody(IMethod method, EntityDeclaration entityDecl, DecompileRun decompileRun, ITypeResolveContext decompilationContext) in offset 833
   at ICSharpCode.Decompiler.CSharp.CSharpDecompiler.DoDecompile(IMethod method, DecompileRun decompileRun, ITypeResolveContext decompilationContext) in offset 292
   at ICSharpCode.Decompiler.CSharp.CSharpDecompiler.DoDecompile(ITypeDefinition typeDef, DecompileRun decompileRun, ITypeResolveContext decompilationContext) in offset 648
   at ICSharpCode.Decompiler.CSharp.CSharpDecompiler.DoDecompileTypes(IEnumerable`1 types, DecompileRun decompileRun, ITypeResolveContext decompilationContext, SyntaxTree syntaxTree) in offset 171
   at ICSharpCode.Decompiler.CSharp.CSharpDecompiler.DecompileWholeModuleAsSingleFile(Boolean sortTypes) in offset 139
   at ICSharpCode.Decompiler.CSharp.CSharpDecompiler.DecompileWholeModuleAsSingleFile() in offset 0
   at ICSharpCode.Decompiler.CSharp.CSharpDecompiler.DecompileWholeModuleAsString() in offset 0
   at ****.Logic.DecompileLogic.DecompileIt(String file, String ProjFilePath, String csprojPath, String Version) in DecompileLogic.cs:line 20
   at ****.Logic.Nuget.ProcessICWS_NetStandard(String PackageID, Version Version, DirectoryInfo bin_info) in Nuget.cs:line 385
   at ****.Logic.Nuget.ProcessICWS(String ExtractPath, String PackageID, Version Version) in Nuget.cs:line 144
   at ****.JobLogic.Process_CIC_ICWS_MSI(Version version, String msi) in JobDefinition.cs:line 368
   at ****.JobLogic.ProcessIso(String iso, IsoType isoType) in JobDefinition.cs:line 574 Error decompiling @06000004 ININ.WebServices.Core.HeaderUtilities.ApplyHeadersToRequest

Details

• Product in use: ICSharpCode.Decompiler nuget package
• Version in use: 6.2.1.6137
• Any other relevant information to the issue, or your interest in contributing a fix.

[kellcomnet2]

https://www.dropbox.com/s/83m6rgiqfbhr074/DecompileErrorReproduce.zip?dl=0

[kellcomnet2]

OK, some additional research on this, ICSharpCode.Decompiler references Humanizer.Core >= 2.2.0 while efcore references Humanizer.Core >= 2.8.26

[siegfriedpammer]

yes, there is a breaking change in Humanizer.Core:

The decompiler expects: System.String Humanizer.InflectorExtensions.Singularize(System.String, Boolean)
The newer Humanizer only offers: System.String Humanizer.InflectorExtensions.Singularize(System.String, Boolean, Boolean).

The breaking change is due to the added optional parameter. Note that both are from the same major version, seems like Humanizer does not follow semver rules... not sure how we could fix this.

[siegfriedpammer]

Not sure, if updating to a newer version of Humanizer is a good idea. @dgrunwald @christophwille what do you think?

[kellcomnet2]

Once Humanizer fixes their issue, I wonder how long before ef core pulls in the new package.... sigh.. Thank you for your fast response.

[christophwille]

https://www.nuget.org/packages/Microsoft.CodeAnalysis.CSharp.Workspaces/

This locks in our dependency, right?

[siegfriedpammer]

yes, so I guess, Humanizer should fix their bug.

[christophwille]

fyi, we are considering to copy source the parts of Humanizer (and make internal) we need. That way we could drop the dependency of Humanizer altogether and make the scenarios where a newer version is needed easily possible.