Update to net45 targetframework #1033
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have switched fw's specifically for Roslyn integration. We are not planning on changing this targetting. |
|
Why didn't you go with netstandard2.0;net46;net45? three tfm, three dlls in the nupkg. |
|
Yes of course no pb for having the 3 targetting. For compatibility reasons, I'm don't think FSAC will be able to move to net46. If you don't mind adding net45 to the existings list, it will be perferct. |
|
I have committed a slightly modified version of your changes in 1e14c8f. Not sure, when we will be able to publish a beta for 3.1 on nuget.org. In the meantime you can use our private nuget feed. |
|
this is perfect. thanks. |
siegfriedpammer
added a commit
that referenced
this pull request
Jan 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning to include ICSharpCode.Decompiler nuget package to https://github.com/fsharp/FsAutoComplete which is targeting .net 4.5. Can you release a new version of your libs targeting this version ? The only compatibility issue is the use of
Array.emtpy