Some parser related errors are silently ignored

[dschwen]

Reason

Parse tree post-processing by walker classes like the brace expander collect error messages in a vector but rely on the calling class to check for those messages and act. Otherwise the failure will be silent, and (in the case if the brace expander) no substitution will be made.

Design

Make sure all collected errors are checked and emitted as mooseErrors.

Impact

More useful errors for invalid input files.

[dschwen]

MOOSE only example:

b = ${c}
a = 0.06 # Diameter of the pebbles (m).

[Mesh]
  type = SpiralAnnularMesh
  outer_radius = ${a}
[]

returns

*** ERROR ***
Range check failed for parameter Mesh/outer_radius
	Expression: outer_radius>0.
	Value: 0

despite outer_radius being set to 0.06. The Parser gets the raw string "${a}" instead, which converts to Real(0.0).

The expected error would be that ${c} cannot be resolved as c is never defined.

[dschwen]

Prerequisite for this failure seems to be a _required range checked parameter(hereouter_radius`).