Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper references to NEML2/Blackbear? commits in MOOSE commit history #26769

Open
GiudGiud opened this issue Feb 8, 2024 · 1 comment
Open

Improper references to NEML2/Blackbear? commits in MOOSE commit history #26769

GiudGiud opened this issue Feb 8, 2024 · 1 comment
Labels
P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Feb 8, 2024 •
edited
Loading

Bug Description

We need to stop using this commit moving scripts. It's not good.

See commits:

commit 208b5d37e969deaf7b8a9d80ed6b616de5a837fe
Author: Logan Harbour <loganhharbour@gmail.com>
Date:   Sat Nov 4 10:03:55 2023 -0600

    Use required_submodule instead for checking for NEML2 (#26450)
    
    This works pretty poorly when you have NEML2 out of tree, but
    it's good enough for now. Eventually we should be able to get
    configure options and flags into the test harness
    
    refs #369

or

commit 91227253ca5c0c8174036ba6f2680f911fbb6a19
Author: Gary Hu <thu@anl.gov>
Date:   Thu Nov 2 12:28:38 2023 -0500

    Fix valgrind errors with NEML2 (#26450)
    
    close #365

Steps to Reproduce

look at moose commit history in that range git log b22396..907c86

Impact

SQA troubles to keep @permcody and @cticenhour up at night
@GiudGiud GiudGiud added P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations. labels Feb 8, 2024
@GiudGiud GiudGiud changed the title Improper references to NEML2 commits in MOOSE commit history Improper references to NEML2/Blackbear? commits in MOOSE commit history Feb 8, 2024
@cticenhour
Copy link
Member

@hugary1995 @loganharbour are the messages in the example commits above from BlackBear (and therefore reference BlackBear issues)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: minor A defect that does not affect the accuracy of results. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cticenhour @GiudGiud