Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent XYDelaunay from Creating Default Boundary IDs That Conflict with the IDs of Its Stitched Holes. #27828

Closed
miaoyinb opened this issue Jun 7, 2024 · 0 comments · Fixed by #27829
Closed

Prevent XYDelaunay from Creating Default Boundary IDs That Conflict with the IDs of Its Stitched Holes. #27828

miaoyinb opened this issue Jun 7, 2024 · 0 comments · Fixed by #27829
Labels
T: task An enhancement to the software.

Comments

@miaoyinb
Copy link
Contributor

miaoyinb commented Jun 7, 2024

Motivation

If not specified, XYDelaunayGenerator assigns 0 for the external boundary, and 1,2,... for the hole boundaries. However, if the hole meshes are stitched to the generated triangulation mesh, it is possible that the hole meshes already contain these boundary IDs, which might lead to difficulties in following simulation setup.

Design

Improve the default boundary IDs generation algorithm to avert this kind of conflicts.

Impact

Better user experience.
@miaoyinb miaoyinb added the T: task An enhancement to the software. label Jun 7, 2024
miaoyinb added a commit to miaoyinb/moose that referenced this issue Jun 7, 2024
@miaoyinb
Improve XYDelaunay Boundary ID Assignment
f1724ec 
closes idaholab#27828
@miaoyinb miaoyinb mentioned this issue Jun 7, 2024
Merged
miaoyinb added a commit to miaoyinb/moose that referenced this issue Jun 8, 2024
@miaoyinb
Improve XYDelaunay Boundary ID Assignment
b352917 
closes idaholab#27828
abanki1 pushed a commit to abanki1/moose that referenced this issue Jul 11, 2024
@miaoyinb
Improve XYDelaunay Boundary ID Assignment
22e6746 
closes idaholab#27828
N4hom pushed a commit to N4hom/moose that referenced this issue Jul 30, 2024
@miaoyinb @N4hom
Improve XYDelaunay Boundary ID Assignment
a9223f3 
closes idaholab#27828
Leni-Yeo pushed a commit to Leni-Yeo/moose that referenced this issue Aug 28, 2024
@miaoyinb
Improve XYDelaunay Boundary ID Assignment
e6d76e7 
closes idaholab#27828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve XYDelaunay Boundary ID Assignment miaoyinb/moose
1 participant
@miaoyinb