Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEML2 material model does not handle solve failure event correctly #27904

Closed
hugary1995 opened this issue Jun 14, 2024 · 0 comments · Fixed by #27966
Closed

NEML2 material model does not handle solve failure event correctly #27904

hugary1995 opened this issue Jun 14, 2024 · 0 comments · Fixed by #27966
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@hugary1995
Copy link
Contributor

Bug Description

When an FEM solve fails, NEML2 material model does not handle the roll-back of solution state correctly.

Steps to Reproduce

This can be easily seen by manually failing a time step using the Terminator.

Impact

This prevents us from getting the correct solution when a solve fails (or fingers crossed the solve never fails).

[Optional] Diagnostics

No response
@hugary1995 hugary1995 added T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. labels Jun 14, 2024
hugary1995 added a commit to hugary1995/moose that referenced this issue Jun 14, 2024
@hugary1995
Allow NEML2 material models to work correctly when an FEM solve fails
8b8832a 
- Add a SolveFailedInterface which is very similar to MeshChangedInterface.
- Handle the solve failure event in ExecuteNEML2Model by rolling back stateful data.

close idaholab#27904
@hugary1995 hugary1995 mentioned this issue Jun 14, 2024
Closed
hugary1995 added a commit to hugary1995/moose that referenced this issue Jun 22, 2024
@hugary1995
Store NEML2 stateful data in MOOSE-managed material properties
2f86ebb 
close idaholab#27904
@hugary1995 hugary1995 mentioned this issue Jun 22, 2024
Merged
kyleeswanson pushed a commit to kyleeswanson/moose that referenced this issue Jun 25, 2024
@hugary1995
Store NEML2 stateful data in MOOSE-managed material properties
4a5ac50 
close idaholab#27904
jmeier pushed a commit to jmeier/moose that referenced this issue Jun 26, 2024
@hugary1995 @jmeier
Store NEML2 stateful data in MOOSE-managed material properties
154b881 
close idaholab#27904
abanki1 pushed a commit to abanki1/moose that referenced this issue Jul 11, 2024
@hugary1995
Store NEML2 stateful data in MOOSE-managed material properties
a7c3239 
close idaholab#27904
N4hom pushed a commit to N4hom/moose that referenced this issue Jul 30, 2024
@hugary1995 @N4hom
Store NEML2 stateful data in MOOSE-managed material properties
a21e208 
close idaholab#27904
Leni-Yeo pushed a commit to Leni-Yeo/moose that referenced this issue Aug 28, 2024
@hugary1995
Store NEML2 stateful data in MOOSE-managed material properties
55088e3 
close idaholab#27904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
1 participant
@hugary1995