Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Refactor RunApp and FileTester" #19258

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Revert "Refactor RunApp and FileTester" #19258

merged 1 commit into from
Oct 29, 2021

Conversation

milljm
Copy link
Member

@milljm milljm commented Oct 29, 2021

Reverts #18988

Re-open #18974

@milljm milljm force-pushed the revert-18988-18974-fix-duplicate-out branch from 6def137 to c84650c Compare October 29, 2021 17:16
loganharbour
loganharbour previously approved these changes Oct 29, 2021
View reviewed changes
@loganharbour loganharbour added the PR: Auto Merge Add this label to have CIVET merge on success label Oct 29, 2021
@milljm
Copy link
Member Author

milljm commented Oct 29, 2021

Once this is merged, #19257 can be closed.

@moosebuild
Copy link
Contributor

Job Documentation on c84650c wanted to post the following:

View the site here

This comment will be updated on new commits.

@YaqiWang
Copy link
Contributor

Looks messy............ I am looking into Griffin.

@loganharbour loganharbour dismissed their stale review October 29, 2021 19:23

reword review

loganharbour
loganharbour approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@loganharbour loganharbour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is being merged with failing and incomplete tests. It will fail on next. Merge will allow application developers to use the fixes for correcting their applications.

@loganharbour loganharbour merged commit 3e02cca into next Oct 29, 2021
@loganharbour loganharbour deleted the revert-18988-18974-fix-duplicate-out branch October 29, 2021 19:24
lindsayad added a commit to lindsayad/moose that referenced this pull request Oct 29, 2021
@lindsayad
Fixup a couple python unit tests
d25d8f4 
Refs idaholab#19258
@lindsayad lindsayad mentioned this pull request Oct 29, 2021
Merged
recuero added a commit to recuero/moose that referenced this pull request Oct 29, 2021
@recuero
Disable non-sparse testing for some mortar continuity convergence tes…
7cd5559 
…ts (idaholab#19258)

These tests are failing with PETSc errors when running with the non-sparse recipe.

[0]PETSC ERROR: Argument out of range
[0]PETSC ERROR: New nonzero at (1,12) caused a malloc
Use MatSetOption(A, MAT_NEW_NONZERO_ALLOCATION_ERR, PETSC_FALSE) to turn off this check
[0]PETSC ERROR: See https://www.mcs.anl.gov/petsc/documentation/faq.html for trouble shooting.
[0]PETSC ERROR: Petsc Release Version 3.15.1, unknown
[0]PETSC ERROR: /ramdisk/civet/build_0/moose/test/moose_test-opt on a arch-moose named meowbuild32.hpc.inl.gov by moosetest Fri Oct 29 12:18:48 2021
[0]PETSC ERROR: Configure options --with-make-np=16 --download-hypre=1 --with-debugging=no --with-shared-libraries=1 --download-fblaslapack=1 --download-metis=1 --download-ptscotch=1 --download-parmetis=1 --download-superlu_dist=1 --download-mumps=1 --download-strumpack=1 --download-scalapack=1 --download-slepc=1 --with-mpi=1 --with-cxx-dialect=C++11 --with-fortran-bindings=0 --with-sowing=0 --with-64-bit-indices --with-make-np=20 --with-make-load=60
[0]PETSC ERROR: #1 MatSetValues_SeqAIJ() at /ramdisk/civet/build_0/moose/petsc/src/mat/impls/aij/seq/aij.c:511
[0]PETSC ERROR: idaholab#2 MatSetValues() at /ramdisk/civet/build_0/moose/petsc/src/mat/interface/matrix.c:1401
application called MPI_Abort(MPI_COMM_WORLD, 1) - process 0
recuero added a commit to recuero/moose that referenced this pull request Oct 29, 2021
@recuero
Disable non-sparse testing for some mortar continuity convergence tes…
2d3d7e5 
…ts (idaholab#19258)

These tests are failing with PETSc errors when running with the non-sparse recipe.

[0]PETSC ERROR: Argument out of range
[0]PETSC ERROR: New nonzero at (1,12) caused a malloc
Use MatSetOption(A, MAT_NEW_NONZERO_ALLOCATION_ERR, PETSC_FALSE) to turn off this check
[0]PETSC ERROR: Petsc Release Version 3.15.1, unknown
[0]PETSC ERROR: /ramdisk/civet/build_0/moose/test/moose_test-opt on a arch-moose named meowbuild32.hpc.inl.gov by moosetest Fri Oct 29 12:18:48 2021
[0]PETSC ERROR: Configure options --with-make-np=16 --download-hypre=1 --with-debugging=no --with-shared-libraries=1 --download-fblaslapack=1 --download-metis=1 --download-ptscotch=1 --download-parmetis=1 --download-superlu_dist=1 --download-mumps=1 --download-strumpack=1 --download-scalapack=1 --download-slepc=1 --with-mpi=1 --with-cxx-dialect=C++11 --with-fortran-bindings=0 --with-sowing=0 --with-64-bit-indices --with-make-np=20 --with-make-load=60
[0]PETSC ERROR: 1 MatSetValues_SeqAIJ() at /ramdisk/civet/build_0/moose/petsc/src/mat/impls/aij/seq/aij.c:511
[0]PETSC ERROR: 2 MatSetValues() at /ramdisk/civet/build_0/moose/petsc/src/mat/interface/matrix.c:1401
application called MPI_Abort(MPI_COMM_WORLD, 1) - process 0
@lindsayad
Copy link
Member

I'm glad we moved hell and high-water to get this fixed. I have a long standing development branch that I rebased onto a point in between this and #18988. I had a bunch of merge conflicts, but I thought I had fixed them appropriately because when I ran my test suite, all the new tests passed. But now rebasing after this point they fail, and going back to the in-between point (I had a old temporary branch at that point), if I run with -v I see that it should have failed then too. Now what I don't have is a branch pointing to my development point before #18988 ... so I'm going to see just how good I am with git reflog now

@lindsayad
Copy link
Member

lindsayad commented Nov 4, 2021 •
edited
Loading

Well sorting through git reflog was pretty easy ... and the conclusion was that the test actually never passed 😆 I thought I had fixed a problem I had banged my head against the wall for for weeks about ... and it was only because the test harness was playing a mean trick on me 😆 😭

@lindsayad lindsayad mentioned this pull request Nov 4, 2021
Closed
@loganharbour loganharbour mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganharbour loganharbour loganharbour approved these changes

Assignees
No one assigned
Labels
PR: Auto Merge Add this label to have CIVET merge on success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@milljm @moosebuild @YaqiWang @lindsayad @loganharbour