Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extrapolation option to TimeSequenceStepperBase #24873

Merged

Conversation

joshuahansel
Copy link
Contributor

Closes #24868

@joshuahansel joshuahansel self-assigned this Jun 29, 2023
@moosebuild
Copy link
Contributor

moosebuild commented Jun 30, 2023

Job Coverage on e81a9af wanted to post the following:

Framework coverage

52fafc #24873 e81a9a
Total Total +/- New
Rate 85.55% 85.55% +0.00% 100.00%
Hits 89151 89159 +8 10
Misses 15053 15054 +1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Jun 30, 2023

Job Documentation on e81a9af wanted to post the following:

View the site here

This comment will be updated on new commits.

@joshuahansel joshuahansel force-pushed the time-sequence-stepper-last-step branch from c5dcc33 to f0ae87e Compare June 30, 2023 12:58
@joshuahansel joshuahansel marked this pull request as ready for review July 3, 2023 13:15
@joshuahansel joshuahansel force-pushed the time-sequence-stepper-last-step branch from 7bc6dd0 to 4d27335 Compare July 3, 2023 18:07
@GiudGiud
Copy link
Contributor

GiudGiud commented Jul 5, 2023

so wrt to your slack message, should this go forward?

@joshuahansel
Copy link
Contributor Author

so wrt to your slack message, should this go forward?

It's true that I'll no longer be needing this change for any immediate work because I won't need to use this time stepper. However, I think the change could potentially still be beneficial. I don't know if anyone will ever use it, but I think it's an improvement.

@joshuahansel joshuahansel merged commit bc7f9c9 into idaholab:next Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow different behavior past last time value in TimeSequenceStepper
3 participants