Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libMesh submodule update #27273

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Conversation

roystgnr
Copy link
Contributor

@roystgnr roystgnr commented Apr 3, 2024

Summary of changes:

  • Improved TriangulatorInterface compatibility with quadratic elements
    in boundary and hole meshes, including adjusting triangulation
    elements to match curved boundaries. This feature is not yet
    compatible with mid-triangulation boundary refinement.

  • Added scaling options to Empirical Interpolation Method in
    Reduced-Basis code, handling for cases with linearly dependent
    data, and update plotting.

  • Fixed bugs in visualization output of Lagrange data on Tri7, in
    DirichletBoundary application on nodesets generated from sidesets,
    and in FEMContext quadrature selection for cases where the first
    variable of a system is higher-order than any of the variables being
    queried by the context. This last fix prevents excessive numbers of
    quadrature points from being used in some MOOSE GeneralField
    transfer operations.

    This should fix Incorrect results for general field transfer test #26605

cticenhour and others added 4 commits April 3, 2024 08:24
Create April 2024 template

Refs idaholab#11447
Refs #0

Summary of changes:

- Improved TriangulatorInterface compatibility with quadratic elements
  in boundary and hole meshes, including adjusting triangulation
  elements to match curved boundaries.  This feature is not yet
  compatible with mid-triangulation boundary refinement.
- Added scaling options to Empirical Interpolation Method in
  Reduced-Basis code, handling for cases with linearly dependent
  data, and update plotting.
- Fixed bugs in visualization output of Lagrange data on Tri7, in
  `DirichletBoundary` application on nodesets generated from sidesets,
  and in FEMContext quadrature selection for cases where the first
  variable of a system is higher-order than any of the variables being
  queried by the context.  This last fix prevents excessive numbers of
  quadrature points from being used in some MOOSE GeneralField
  transfer operations.
The FEMContext bug we just fixed was affecting 3 of our regression
tests...
@roystgnr
Copy link
Contributor Author

roystgnr commented Apr 3, 2024

(I've cherry-picked from #27226 here so we don't get conflicts with the April news update)

libmesh Show resolved Hide resolved
libmesh Show resolved Hide resolved
@moosebuild
Copy link
Contributor

Job Precheck on 9fffa07 wanted to post the following:

The following file(s) are changed:

conda/libmesh/meta.yaml

The libmesh conda configuration has changed; ping @idaholab/moose-dev-ops

Copy link
Member

@milljm milljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Conda stuff looks good to me!

@roystgnr
Copy link
Contributor Author

roystgnr commented Apr 3, 2024

Whoa - did I get it right on the first try? I'm surprisingly kind of disappointed. It feels like getting to the end of a Rube Goldberg machine, and sure the cube of sugar I wanted in my tea is now in there, but was there really no room to squeeze in another ravenous toucan or something first?

@moosebuild
Copy link
Contributor

Job Documentation on 9fffa07 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Docker moose on 9fffa07 : invalidated by @roystgnr

Kicking "Failed to run Docker hello-world"

@moosebuild
Copy link
Contributor

Job Coverage on 9fffa07 wanted to post the following:

Framework coverage

b02bb1 #27273 9fffa0
Total Total +/- New
Rate 85.15% 85.15% -0.00% -
Hits 102638 102637 -1 0
Misses 17899 17900 +1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Test timings on 9fffa07 wanted to post the following:

View timings here

This comment will be updated on new commits.

@roystgnr
Copy link
Contributor Author

roystgnr commented Apr 3, 2024

Jason seems to have traced the TMAP8 install failure down to a recent PR there, and it's affecting far more than this PR, so we should be good to merge.

@roystgnr roystgnr merged commit 9d7163f into idaholab:next Apr 3, 2024
101 of 102 checks passed
@roystgnr roystgnr deleted the libmesh_update_20240403 branch April 3, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect results for general field transfer test
4 participants