Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding option to use absolute value in ElementIntegralPostprocessor. #28163

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Adding option to use absolute value in ElementIntegralPostprocessor. #28163

merged 1 commit into from
Jul 17, 2024

Conversation

SudiptaBiswas
Copy link
Contributor

Closes #28162

GiudGiud
GiudGiud reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@GiudGiud GiudGiud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont mind this but you can already do it with:

  • define a ParsedFunctorMaterial with the absolute value of the variable
  • use the element integral pp for functors

@SudiptaBiswas
Copy link
Contributor Author

I dont mind this but you can already do it with:

  • define a ParsedFunctorMaterial with the absolute value of the variable
  • use the element integral pp for functors

Agree. But I think this would simplify things. Thanks for reviewing.

@GiudGiud
Copy link
Contributor

lets squash #3 in #1 before testing/ merging please

@SudiptaBiswas
Copy link
Contributor Author

lets squash #3 in #1 before testing/ merging please

Do you mean, only have 1 commit or just squash the third one?

@SudiptaBiswas
Copy link
Contributor Author

lets squash #3 in #1 before testing/ merging please

Do you mean, only have 1 commit or just squash the third one?

I did the former.

@GiudGiud
Copy link
Contributor

ok that's fine.
I meant sqaush the 3rd commit into the 1st one

@moosebuild
Copy link
Contributor

Job Documentation on bd9d205 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage on bd9d205 wanted to post the following:

Framework coverage

182f6e #28163 bd9d20
Total Total +/- New
Rate 85.07% 85.07% +0.00% 100.00%
Hits 104585 104591 +6 7
Misses 18360 18359 -1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

GiudGiud
GiudGiud approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the contribution

@GiudGiud GiudGiud merged commit 9353c8c into idaholab:next Jul 17, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiudGiud GiudGiud GiudGiud approved these changes

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to use absolute value for ElementIntegralVariablePostprocessor
3 participants
@SudiptaBiswas @GiudGiud @moosebuild