Skip to content

add Dockerfile, optimize ReadMe & fix Package name #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 7, 2022
Merged

add Dockerfile, optimize ReadMe & fix Package name #2

merged 5 commits into from
Jan 7, 2022

Conversation

aruis
Copy link
Contributor

@aruis aruis commented Jan 7, 2022

Fix package

TechQuery
TechQuery requested changes Jan 7, 2022
View reviewed changes
Dockerfile Outdated
Comment on lines 3 to 4
# 构建之前需要先确保本地有编译好的jar包，执行下面这个命令即可
#./gradlew build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 除非是专门用于中国业务的脚手架，代码注释最好用中文
  2. 这个本地执行的命令好像也可以写在 Dockerfile 里吧？

@TechQuery TechQuery changed the title Fix package add Dockerfile & fix Package name Jan 7, 2022
@TechQuery TechQuery changed the title add Dockerfile & fix Package name add Dockerfile, optimize ReadMe & fix Package name Jan 7, 2022
@TechQuery TechQuery added the enhancement New feature or request label Jan 7, 2022
@TechQuery TechQuery merged commit 0d22412 into idea2app:master Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TechQuery TechQuery TechQuery approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
开源项目
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aruis @TechQuery