avoid download on import #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also update the relevant test cases please? |
|
Thanks @tanujjain. All tests are passing on my side, I added an extra test to check that the model is not downloaded at import time. |
|
please merge this branch to Master！ |
|
@tanujjain any thoughts ? I added a new test and they were all passing on my side! |
|
@tanujjain can we merge ? |
Signed-off-by: Tanuj Jain <tanujjain@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Prevent downloading the mobilenetV3 model at import time.
Why
It creates an extra log that can be disturbing when integrating the repo in applications
How
Set the default argument to None, and evaluate and download the model within the
__init__method only (since default args are evaluated at import time but the code in__init__is not run)See Issue: #200