Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: startup scripts to MWAA resource #116

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

barrysteyn
Copy link
Contributor

The ability to pass startup_script_s3_path and startup_script_s3_object_version to underlying MWAA terraform resource.

@barrysteyn barrysteyn changed the title feat:startup scripts to MWAA resource feat: startup scripts to MWAA resource Apr 28, 2023
@barrysteyn
Copy link
Contributor Author

@mgerlach @jdiebold Could you guys look into please merging this? Also, the generate docs seems to be failing because it can't access my forked repo. I think that could be an error in that GH action.

@mgerlach
Copy link
Contributor

@mgerlach @jdiebold Could you guys look into please merging this? Also, the generate docs seems to be failing because it can't access my forked repo. I think that could be an error in that GH action.

Hi @barrysteyn , thanks for the PR. Yes, that generate docs action fails on forks, it's not ideal. We may want to run it after merging rather than try to modify PRs...

The change looks good, but I'm on the road right now (it's Fri evening here in Berlin), will handle it in about 1h or so, hope that's ok.

@barrysteyn
Copy link
Contributor Author

@mgerlach That should be fine. Thank you so much for the quick response.

@mgerlach
Copy link
Contributor

mgerlach commented Apr 28, 2023

@barrysteyn Could you try to create the PR again, but this time against the fork_prs branch of the idealo repo? You might have to fork again, including all branches.

Idea is that we can then create a PR from fork_pr against main, preserving your commits with you as author, but enabling the generate docs action to modify that new PR created by us.

@barrysteyn
Copy link
Contributor Author

Sure thing... I will do this now....

@barrysteyn barrysteyn changed the base branch from main to fork_prs April 28, 2023 20:10
@barrysteyn
Copy link
Contributor Author

Done!

@mgerlach mgerlach merged commit e4c8250 into idealo:fork_prs Apr 28, 2023
mgerlach added a commit that referenced this pull request Apr 28, 2023
* feat: startup scripts from MWAA resource (#116)

Co-authored-by: Barry Steyn <bsteyn@linkedin.com>

* terraform-docs: automated action

---------

Co-authored-by: Barry Steyn <barrysteyn@users.noreply.github.com>
Co-authored-by: Barry Steyn <bsteyn@linkedin.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mgerlach
Copy link
Contributor

Released by #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants