-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: startup scripts to MWAA resource #116
Conversation
099c0f7
to
0c24745
Compare
0c24745
to
7a97203
Compare
Hi @barrysteyn , thanks for the PR. Yes, that generate docs action fails on forks, it's not ideal. We may want to run it after merging rather than try to modify PRs... The change looks good, but I'm on the road right now (it's Fri evening here in Berlin), will handle it in about 1h or so, hope that's ok. |
@mgerlach That should be fine. Thank you so much for the quick response. |
@barrysteyn Could you try to create the PR again, but this time against the fork_prs branch of the idealo repo? You might have to fork again, including all branches. Idea is that we can then create a PR from fork_pr against main, preserving your commits with you as author, but enabling the generate docs action to modify that new PR created by us. |
Sure thing... I will do this now.... |
Done! |
* feat: startup scripts from MWAA resource (#116) Co-authored-by: Barry Steyn <bsteyn@linkedin.com> * terraform-docs: automated action --------- Co-authored-by: Barry Steyn <barrysteyn@users.noreply.github.com> Co-authored-by: Barry Steyn <bsteyn@linkedin.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Released by #120 |
The ability to pass
startup_script_s3_path
andstartup_script_s3_object_version
to underlying MWAA terraform resource.