Skip to content

Conversation

avgprog
Copy link
Contributor

@avgprog avgprog commented Jan 28, 2021

Resolves #165. Changes done -

  1. Added CylindricalStorageInputCopyBuilder, ThermalBusInputCopyBuilder and ThermalHouseInputCopyBuilder to classes CylindricalStorageInput, ThermalBusInput and ThermalHouseInput respectively.

Next, I will work on test cases and code refinement.

@avgprog avgprog changed the title #165 Added builder implementations to several thermal input models Added builder implementations to the required thermal input models Jan 28, 2021
@avgprog
Copy link
Contributor Author

avgprog commented Jan 28, 2021

Added test cases to check the builder implementations added to the thermal input models.

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #270 (01ba298) into dev (1b2a578) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #270      +/-   ##
============================================
+ Coverage     78.13%   78.31%   +0.17%     
- Complexity     1938     1941       +3     
============================================
  Files           246      246              
  Lines          7839     7885      +46     
  Branches        746      746              
============================================
+ Hits           6125     6175      +50     
+ Misses         1297     1293       -4     
  Partials        417      417              
Impacted Files Coverage Δ Complexity Δ
.../models/input/thermal/CylindricalStorageInput.java 85.24% <0.00%> (+11.56%) 11.00% <0.00%> (ø%)
...tamodel/models/input/thermal/ThermalUnitInput.java 56.00% <0.00%> (+13.89%) 4.00% <0.00%> (ø%)
...amodel/models/input/thermal/ThermalHouseInput.java 76.31% <0.00%> (+22.14%) 6.00% <0.00%> (+1.00%)
...atamodel/models/input/thermal/ThermalBusInput.java 88.88% <0.00%> (+22.22%) 3.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac68693...01ba298. Read the comment docs.

@avgprog avgprog marked this pull request as ready for review February 3, 2021 07:52
…mal input models copy builder implementations and associated test cases
@avgprog avgprog requested a review from ckittl February 11, 2021 10:32
@ckittl ckittl merged commit 375a2dd into dev Feb 11, 2021
@ckittl ckittl deleted the sb/#165-addingBuilderForThermalInputModels branch February 11, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add copy builder implementations for thermal instances
2 participants