-
Notifications
You must be signed in to change notification settings - Fork 7
Added builder implementations to the required thermal input models #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test cases to check the builder implementations added to the thermal input models. |
avgprog
added a commit
that referenced
this pull request
Jan 29, 2021
Codecov Report
@@ Coverage Diff @@
## dev #270 +/- ##
============================================
+ Coverage 78.13% 78.31% +0.17%
- Complexity 1938 1941 +3
============================================
Files 246 246
Lines 7839 7885 +46
Branches 746 746
============================================
+ Hits 6125 6175 +50
+ Misses 1297 1293 -4
Partials 417 417
Continue to review full report at Codecov.
|
ckittl
suggested changes
Feb 4, 2021
src/main/java/edu/ie3/datamodel/models/input/thermal/CylindricalStorageInput.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/thermal/ThermalBusInput.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/thermal/ThermalHouseInput.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/thermal/CylindricalStorageInput.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/thermal/ThermalHouseInput.java
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/models/input/thermal/CylindricalStorageInputTest.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/models/input/thermal/ThermalHouseInputTest.groovy
Outdated
Show resolved
Hide resolved
…mal input models copy builder implementations and associated test cases
ckittl
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #165. Changes done -
CylindricalStorageInputCopyBuilder
,ThermalBusInputCopyBuilder
andThermalHouseInputCopyBuilder
to classesCylindricalStorageInput
,ThermalBusInput
andThermalHouseInput
respectively.Next, I will work on test cases and code refinement.