-
Notifications
You must be signed in to change notification settings - Fork 7
Extracting mapping source from former time series source #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #276 +/- ##
============================================
- Coverage 78.29% 77.98% -0.32%
Complexity 1950 1950
============================================
Files 247 249 +2
Lines 7911 7935 +24
Branches 747 749 +2
============================================
- Hits 6194 6188 -6
- Misses 1299 1321 +22
- Partials 418 426 +8 Continue to review full report at Codecov.
|
!test |
What did I do here? I modularized the time series sources a bit further:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution. 👍🏼
Coverage is also fine for now, as mainly equals or exceptions are not tested.
Just had a few minor remarks that should be fast addressable. :-)
!test |
Resolves #274