Skip to content

Conversation

johanneshiry
Copy link
Member

Bugfixes as #350 did not pass quality gate @ main branch

@johanneshiry johanneshiry requested a review from ckittl May 21, 2021 12:18
@johanneshiry johanneshiry self-assigned this May 21, 2021
@johanneshiry johanneshiry added the release Describes a release task label May 21, 2021
@johanneshiry johanneshiry added this to the Version 2.0 milestone May 21, 2021
@johanneshiry
Copy link
Member Author

!test

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #357 (606f731) into main (154cc7b) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #357      +/-   ##
============================================
+ Coverage     78.52%   78.57%   +0.04%     
- Complexity     2044     2048       +4     
============================================
  Files           254      254              
  Lines          8131     8120      -11     
  Branches        771      767       -4     
============================================
- Hits           6385     6380       -5     
+ Misses         1358     1352       -6     
  Partials        388      388              
Impacted Files Coverage Δ Complexity Δ
.../ie3/datamodel/io/source/csv/CsvWeatherSource.java 76.82% <0.00%> (-3.44%) 20.00% <0.00%> (ø%)
.../models/input/thermal/CylindricalStorageInput.java 86.88% <0.00%> (+1.63%) 12.00% <0.00%> (+1.00%)
.../ie3/datamodel/io/connectors/CsvFileConnector.java 79.87% <0.00%> (+2.09%) 33.00% <0.00%> (ø%)
...imeseries/IndividualTimeSeriesMetaInformation.java 50.00% <0.00%> (+8.33%) 4.00% <0.00%> (+1.00%)
.../ie3/datamodel/io/csv/FileNameMetaInformation.java 70.00% <0.00%> (+10.00%) 4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 154cc7b...606f731. Read the comment docs.

ckittl
ckittl previously approved these changes May 21, 2021
@ckittl ckittl force-pushed the rel/jh/#349-v-2-0-0 branch from 2345de6 to 606f731 Compare May 21, 2021 14:05
@ckittl ckittl merged commit cb34566 into main May 21, 2021
@ckittl ckittl deleted the rel/jh/#349-v-2-0-0 branch May 21, 2021 14:37
@johanneshiry johanneshiry restored the rel/jh/#349-v-2-0-0 branch May 21, 2021 16:11
@johanneshiry johanneshiry deleted the rel/jh/#349-v-2-0-0 branch May 21, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Describes a release task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants