Improving validation utils #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
src/main/java/edu/ie3/datamodel/utils/validation/ValidationUtils.java
Outdated
Show resolved
Hide resolved
…ad-of-returning-Optionals' into ms/#758-improving-ValidationUtils
src/main/java/edu/ie3/datamodel/utils/validation/ValidationUtils.java
Outdated
Show resolved
Hide resolved
…ad-of-returning-Optionals' into ms/#758-improving-ValidationUtils
src/main/java/edu/ie3/datamodel/utils/validation/ConnectorValidationUtils.java
Outdated
Show resolved
Hide resolved
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/770.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diffWant it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/770.diff | git applyOnce you're satisfied, commit and push your changes in your project. Footnotes |
# Conflicts: # CHANGELOG.md # src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvRawGridSourceTest.groovy
|
!test |
sebastian-peter
requested changes
Jul 28, 2023
src/main/java/edu/ie3/datamodel/models/input/container/InputContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/container/InputContainer.java
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/utils/validation/ValidAssetInput.groovy
Outdated
Show resolved
Hide resolved
…s' into ms/#758-improving-ValidationUtils
Removed rarely used methods of Try Enhanced tests for Try
Removed unnecessary type parameters and method definitions
Reinstated narrower checking of syspart. validation
sebastian-peter
previously approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Ok, we got it know imho. I only adapted some minor stuff. Thanks for doing the large part of the job, @staudtMarius!
sebastian-peter
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #758