Skip to content

Adjust wrong unit comments #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2023
Merged

Adjust wrong unit comments #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4e5933
adjust comments
t-ober May 8, 2023
66b6ad6
fix typo
t-ober May 8, 2023
6ca95ac
adjust missing entry
t-ober May 8, 2023
6203d42
add changelog entry
t-ober May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Allow hierarchic grid structure for JointGridContainer [#768](https://github.com/ie3-institute/PowerSystemDataModel/issues/768)

### Fixed
- Fixed wrong rated power unit hint [#804](https://github.com/ie3-institute/PowerSystemDataModel/issues/804)


### Changed
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/edu/ie3/datamodel/models/input/connector/type/Transformer2WTypeInput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class Transformer2WTypeInput extends AssetTypeInput {
private final ComparableQuantity<ElectricResistance> rSc;
/** Short circuit reactance (typically in Ohm) */
private final ComparableQuantity<ElectricResistance> xSc;
/** Rated apparent power (typically in MVA) */
/** Rated apparent power (typically in kVA) */
private final ComparableQuantity<Power> sRated;
/** Rated voltage of the high voltage winding (typically in kV) */
private final ComparableQuantity<ElectricPotential> vRatedA;
Expand Down Expand Up @@ -46,7 +46,7 @@ public class Transformer2WTypeInput extends AssetTypeInput {
* @param id of the type
* @param rSc Short circuit resistance
* @param xSc Short circuit reactance
* @param sRated Rated apparent power (typically in MVA)
* @param sRated Rated apparent power (typically in kVA)
* @param vRatedA Rated voltage of the high voltage winding
* @param vRatedB Rated voltage of the low voltage winding
* @param gM Phase-to-ground conductance
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/edu/ie3/datamodel/models/input/connector/type/Transformer3WTypeInput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@

/** Describes the type of a {@link edu.ie3.datamodel.models.input.connector.Transformer3WInput} */
public class Transformer3WTypeInput extends AssetTypeInput {
/** Rated apparent power of the high voltage winding (typically in MVA) */
/** Rated apparent power of the high voltage winding (typically in kVA) */
private final ComparableQuantity<Power> sRatedA; // Hv
/** Rated apparent power of the medium voltage winding (typically in MVA) */
/** Rated apparent power of the medium voltage winding (typically in kVA) */
private final ComparableQuantity<Power> sRatedB; // Mv
/** Rated apparent power of the low voltage windings (typically in MVA) */
/** Rated apparent power of the low voltage windings (typically in kVA) */
private final ComparableQuantity<Power> sRatedC; // Lv
/** Rated voltage magnitude of the high voltage winding (typically in kV) */
private final ComparableQuantity<ElectricPotential> vRatedA; // Hv
Expand Down