Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yt: better subtitle support #91

Merged
merged 12 commits into from
Feb 12, 2023
Merged

yt: better subtitle support #91

merged 12 commits into from
Feb 12, 2023

Conversation

iejMac
Copy link
Owner

@iejMac iejMac commented Jan 11, 2023

No description provided.

@iejMac
Copy link
Owner Author

iejMac commented Jan 11, 2023

I think the right way to do this is: If you want to use YT subtitles then don't specify a clip column and let video2dataset do everything for you. If you have some custom subtitles you want to use then produce the clip ranges yourself and set up everything in the parquet during preprocessing

@iejMac iejMac marked this pull request as draft January 11, 2023 01:16
@iejMac iejMac linked an issue Jan 11, 2023 that may be closed by this pull request
4 tasks
@iejMac
Copy link
Owner Author

iejMac commented Jan 11, 2023

clipping works, now need to figure out how to adjust the meta_clips in the clipping subsampler so removes subtitles and only leaves lines="your line" and after that make lines the caption

@iejMac
Copy link
Owner Author

iejMac commented Jan 21, 2023

putting clip as text caption and also separating subtitles by clip works but there's some weird key error in the meta dict: first clip from the video doesn't have the subtitle key, it's always the first one, figure this out

@iejMac iejMac mentioned this pull request Feb 5, 2023
Closed
@iejMac
Copy link
Owner Author

iejMac commented Feb 11, 2023

need to update this and then update the yt metadata example (show you can use clips=subtitles

@iejMac iejMac marked this pull request as ready for review February 11, 2023 08:54
@iejMac iejMac merged commit 5969a67 into main Feb 12, 2023
@iejMac iejMac deleted the subtitle_support branch February 12, 2023 04:40
iejMac added a commit that referenced this pull request Jul 10, 2023
* yt: better subtitle support

* clips work

* overwrite subtitles with correct line

* works

* progress

* cleanup

* update example

* fix black

* revert

* different way

* update this example
iejMac added a commit that referenced this pull request Jul 10, 2023
* yt: better subtitle support

* clips work

* overwrite subtitles with correct line

* works

* progress

* cleanup

* update example

* fix black

* revert

* different way

* update this example
iejMac added a commit that referenced this pull request Jul 11, 2023
* yt: better subtitle support

* clips work

* overwrite subtitles with correct line

* works

* progress

* cleanup

* update example

* fix black

* revert

* different way

* update this example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subtitle support
1 participant