-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yt: better subtitle support #91
Conversation
I think the right way to do this is: If you want to use YT subtitles then don't specify a clip column and let video2dataset do everything for you. If you have some custom subtitles you want to use then produce the clip ranges yourself and set up everything in the parquet during preprocessing |
clipping works, now need to figure out how to adjust the meta_clips in the clipping subsampler so removes subtitles and only leaves lines="your line" and after that make lines the caption |
putting clip as text caption and also separating subtitles by clip works but there's some weird key error in the meta dict: first clip from the video doesn't have the subtitle key, it's always the first one, figure this out |
need to update this and then update the yt metadata example (show you can use clips=subtitles |
* yt: better subtitle support * clips work * overwrite subtitles with correct line * works * progress * cleanup * update example * fix black * revert * different way * update this example
* yt: better subtitle support * clips work * overwrite subtitles with correct line * works * progress * cleanup * update example * fix black * revert * different way * update this example
* yt: better subtitle support * clips work * overwrite subtitles with correct line * works * progress * cleanup * update example * fix black * revert * different way * update this example
No description provided.