This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Clarify that HTTP and TLS go over ports 80 and 443 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
pushed a commit
to cpu/acme
that referenced
this pull request
Oct 28, 2016
Pull request ietf-wg-acme#200 was recently merged to clarify that HTTP and TLS challenge requests must use port 80 and 443 respectively. The "TLS with Server Name Indication (TLS SNI)" section was updated to read: > Open a TLS connection to TCP port 443 the domain name being validated > on the requested port, presenting SAN A in the SNI field. This is a typo ("port 443 the domain name") and also still includes the phrase "on the requested port", which is no longer true. This commit updates the SNI challenge description to fix the typo and to explicitly say that the server MUST use port 443 in the same style/manner as the HTTP edit from ietf-wg-acme#200.
|
I spotted a typo/error introduced by this PR and submitted a follow-up: #202 |
bifurcation
pushed a commit
that referenced
this pull request
Oct 28, 2016
Pull request #200 was recently merged to clarify that HTTP and TLS challenge requests must use port 80 and 443 respectively. The "TLS with Server Name Indication (TLS SNI)" section was updated to read: > Open a TLS connection to TCP port 443 the domain name being validated > on the requested port, presenting SAN A in the SNI field. This is a typo ("port 443 the domain name") and also still includes the phrase "on the requested port", which is no longer true. This commit updates the SNI challenge description to fix the typo and to explicitly say that the server MUST use port 443 in the same style/manner as the HTTP edit from #200.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #190