Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor spec/controllers/locales_controller_spec.rb to spec/request/locale_spec.rb #1826

Closed
bennpham opened this issue Aug 26, 2020 · 2 comments · Fixed by #2019
Closed

Refactor spec/controllers/locales_controller_spec.rb to spec/request/locale_spec.rb #1826

bennpham opened this issue Aug 26, 2020 · 2 comments · Fixed by #2019
Assignees
@brunoocasali
Labels
hacktoberfest refactoring ruby on rails tests

Comments

@bennpham
Copy link
Member

Description

Controller Specs had been obsolete since Rails 5. It is best practice to create request spec instead of controller spec as recommended by the Rspec team.

Recommended Reading:

Resources on Request Spec formatting:

Original Issue: #1815

Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!
@bennpham bennpham mentioned this issue Aug 26, 2020
Closed
25 tasks
@placy2 placy2 self-assigned this Oct 11, 2020
@sebassebas1313
Copy link
Contributor

@placy2 do you mind if I take this?

@placy2
Copy link
Contributor

placy2 commented Jan 12, 2021 •
edited
Loading

Go for it, I believe it's pretty much done, there was just some odd stuff in a couple of the tests that needed deeper knowledge of the repo. @sebassebas1313

@brunoocasali brunoocasali self-assigned this Oct 6, 2021
brunoocasali added a commit that referenced this issue Oct 6, 2021
@brunoocasali
Remove controller spec for locales & Replace with request one
ab07df3 
Closes #1826
@brunoocasali brunoocasali mentioned this issue Oct 6, 2021
Merged
julianguyen pushed a commit that referenced this issue Oct 7, 2021
@brunoocasali @julianguyen
Remove controller spec for locales & Replace with request one
dfe8bfa 
Closes #1826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunoocasali brunoocasali

Labels
hacktoberfest refactoring ruby on rails tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove controller spec for locales & Replace with request one ifmeorg/ifme
5 participants
@julianguyen @brunoocasali @bennpham @placy2 @sebassebas1313