[Issue #1839] Refactor secret_shares controller spec to request spec #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianguyen
reviewed
Oct 4, 2020
…quest/secret_share_spec.rb
camilacampos
force-pushed
the
issue-1839/refactor-secret-shares-spec
branch
from
587ea6d
to
49589b3
Compare
julianguyen
approved these changes
Oct 4, 2020
|
Thank you for merging this pull request with us! If you haven't already, in another pull request, please add yourself to our About page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the tests associated with the SecretSharesController to use RSpec request type tests instead of controller
Corresponding Issue
Fixes #1839
Parent issue: #1815
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!