[Issue #1832] Refactor omniauth callbacks controller spec to request spec #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennpham
reviewed
Oct 13, 2020
There was a problem hiding this comment.
Really good job on this test! I was wondering about how to go about with stubbing the omniauth calls myself when I took a look at this myself so I thought this was a trickier one. I got a few comments around to make the test a bit neater, but overall, this is really good! I'd probably move some of those methods in this test to a stub_omniauth.rb spec support to separate the concerns and in case there's a different test that would require stubbing omniauth as well.
camilacampos
deleted the
issue-1832/refactor_omniauth_callbacks_controller_spec
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This refactors the tests associated with the SecretSharesController to use RSpec request type tests instead of controller
Corresponding Issue
Fixes #1832
Parent issue: #1815
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!