-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wasmd init #23
feat: wasmd init #23
Conversation
f0d92f9
to
3ad8730
Compare
Thanks for the PR. This looks promising. We are testing and reviewing. |
Hello, |
You think there's a chance to develop on Ignite CLI nightly (https://github.com/ignite/cli/releases/tag/nightly) with Cosmos SDK v0.50.1 ? This is freshly released from the Wasm team: https://github.com/CosmWasm/wasmd/tree/v0.50.0 |
Hi, I have examined both the nightly version of ignite and the latest release of wasmd, and it appears that there is a compatibility issue with the new dependency injection solution which utilizes an Uber-like approach. I am currently working on resolving this issue and testing the integration between the two components. I will keep you updated on my progress and welcome any feedback or input you may have. Additionally, I am curious as to why they did not utilize Google's Go Wire solution instead. Thank you |
Thats right, new releases are using depinject so this PR implementation would only be compatible with previous Ignite CLI versions and app chains scaffolded using the original module definitions. It would be good to finish and merge this PR as originally intended and then in a different PR make the changes to support depinject so the cosmwasm Ignite app would eventually have at least two releases, one for the original module definitions and another for the app chains using depinject 👍 |
I will try to review and handle these comments as soon as possible and will update the progress here. Thanks! |
I just pushed my changes and Please let me know what you think about it @jeronimoalbi . if there is anything else let me know. |
@tinaaliakbarpour since the introduction of the marketplace app it's possible for developers to search apps developed by contributors so we are changing Ignite App's README with updates on how to contribute to Ignite Apps. We are planning to have an apps registry to track and index contributions instead of merging all of them in this repository. If you want, as a next step, you could create an empty repo for the app in you personal GitHub profile and then make a PR there with the changes you made in this PR. Development could continue there and if you let me know I can follow it and review that PR 👍 Once the first version is finished you could make a PR to be listed in the registry 🚀 I would also recommend to add a comment in this PR that links to your personal wasm app repository (or PR) indicating that development will continue there. |
Hi @jeronimoalbi. I see that you have implemented the wasm plugin so I don't know how my work could be helpful here. I would appreciate more explanation on that. |
Yes, there is an newly implemented Another interesting improvement could be to use Bubbletea within your app which might potentially make it more user friendly. |
This is my first try to create a plugin to add wasmd to our chain. I tried to use the placeholders already used in ignite but there were some places where I couldn't find a way to find a placeholder to fit so I used replacement for those parts. you can find these in yaml file provided in the placeholder folder under the sections
change
andreplace
. I really appreciate your thoughts about the way I implemented it and also happy to hear new ideas. still working on this repo and trying to create more options like testing and deploying smart contracts. I would really appreciate your suggestions.