-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v0.24.0 #2826
Merged
chore: release v0.24.0 #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #1960 From the cosmos-docs [1], this method `RegisterMsgServer` should be called inside the module `RegisterServices`. The fact that we manage to run a chain w/o that call is still a mistery for now. [1] https://docs.cosmos.network/main/building-modules/messages-and-queries.html#msg-services Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
Fix #1666 If appID is wrong, cosmoscmd is not able to sign a transaction correctly.
* update golangci-lint version * update golangci runners * format and lint fixes
Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com>
* speed up the integration tests remove unnecessary tests and split the app into an app and chain tests * move serve test to chain folder Co-authored-by: ltacker <lucas.bertrand.22@gmail.com>
…ation bug (#2643) * refactor prepare * remove show cache * refactor join * change tests * fix reward height * gofmt * Update ignite/cmd/network_chain_prepare.go Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> * Update ignite/services/network/join.go Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
* add the profile command * add profile queries * profile command * add network profile method and print into the cmd * import sort * fix unit tests for network publish command * use profile interface * fix wrong coord address * grpc error responses * update spn and mocks * fix the profile command and balances * remove omitted fields * fix unit tests * fix unit tests * apply comment suggestions regarding code style * handle not found address * fix imports * fix imports 2 * some fixes = * fix cli * some fixes * goimport * fix test Co-authored-by: ltacker <lucas.bertrand.22@gmail.com>
It should use the query client context. Fix #2656
Add github.com/sonr-io/sonr to the projects being built with Ignite in the root of the docs.
* network connect cmd * rly commands * fetch client id from target chain * change connect logic order * find client state * network connect * remove comments and add TODO's * fetch client id from spn * improve the node client * fecth client id from the monitoring client package * avoid unecessary link * fix get path from relayer * add todo comment * pass session to the nodetime call log * change the client and channel queries * update spn version * update mock campaign queries * remove session from tsrelayer pkg * fix start relayer background job * change create client command to reward release * remove unused context InterfaceRegistry * fetch spn chain id from status * use the chain stake denom * remove duplicated method * fix channel id fetch for spn * add validation for already established and is missing in one of the chains * update spn * make RPC port public * make RPC port public * convert node into a private var for network * fix ibc-go version * refactor: network release (#2572) * fix methods and var names * fix import names * errorIs * remove unused id * refactor create client * simplify start * import * lint Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com> Co-authored-by: Petr Ivanov <petr.ivanov@tendermint.com> Co-authored-by: ltacker <lucas.bertrand.22@gmail.com>
Co-authored-by: lubtd <lubtd@users.noreply.github.com>
* feat: add chain option to enable dependencies verification This option allow to make the call to `go mod verify` optional and disabled by default to avoid issues with module ziphash files when a Go workspace is being used. * feat: add check dependencies flag to chain init, build and serve * feat: add check dependencies flag to network chain commands
* make format * gofumpt
* fix: change `protoc-gen-ts_proto` to generate in random folders The script has a fixed name to comply with `protoc` plugin naming requirements but it it always generated in the same temporary folder which means that concurrent calls would overwrite the `protoc-gen-ts_proto` file. This changeset generates the script in random temporary folders. This fix might help correcting "flaky" integration tests. * refactor(pkg/protoc): add WithCommand option to Generate This allow calling Generate multiple times using a single protoc binary. Otherwise a protoc binary would be created each time Generate is called. * refactor(pkg/cosmosgen): change JS generator to reuse protoc binary * chore: simplify code Co-authored-by: Alex Johnson <alex@shmeeload.xyz> Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
* rename generated file * rename to helpers
…2667) * docs: change blog tutorial to use "blog" as address prefix * docs: change blogclient module to use a single name instead of a URI * docs: change the blogclient app to use "blog" as address prefix * review: update go version in go.mod Co-authored-by: Alex Johnson <alex.johnson@tendermint.com> Co-authored-by: Alex Johnson <alex.johnson@tendermint.com> Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com> Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
* docs: inline docs for the scaffold list command * Add a `list` to the example Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> * Added "for example" Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
…ccounts (#2777) * docs: added a note to distinguish between chain accounts and Ignite accounts * fix: typo Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
* docs: inline docs for scaffold map * fix: long instead of short description * quick format Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
* chore: update changelog * fix: update change log for better redability * chore: add more details to changelog entries Co-authored-by: Denis Fadeev <denis@fadeev.org> * docs: add node command features * Update changelog.md * Update changelog.md * Update changelog.md Co-authored-by: Alex Johnson <alex@shmeeload.xyz> Co-authored-by: Denis Fadeev <denis@fadeev.org> Co-authored-by: Thomas Bruyelle <thomas.bruyelle@tendermint.com> Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
* fix(cosmosclient): call the faucet prior to create the tx Fix #2775 This change restores the behavior we used to have in 0.23, and which has changed with the refac of cosmosclient with the `node` command feat. Calling the faucet (when it is specifically enabled) will ensure the account that broadcasts the tx exists in the target chain. Because the `node` command has a `--generate-only` flag, and because we don't want to create a new account when it's set, this flag is now propagated to the cosmosclient struct. Therefore, the faucet isn't called when the flag is set. This doesn't affect the `network` command because it doesn't use that flag. * test link issue in CL * gh doesn't autolink issues in repo's file * Update changelog.md Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com> * Solve TODO: validate tx msgs * test: cosmosclient.New * test: cosmosclient.WaitForBlockHeight * wip: test cosmosclient.Account * test: cosmosclient.Account * test: improve cosmosclient.WaitForBlockHeight * test: cosmosclient.Address * test: cosmosclient.Status * refac: cosmosclient.Address - dont need to use sdkconfig prefix since we have can just call account.Address(prefix) - improve error message by using GetByName directly * refac: no need for private account func * restore cosmosaccount.Keyring public * style: rename var * add CL entry * Update changelog.md Co-authored-by: Alex Johnson <alex@shmeeload.xyz> * style: var names * merged too fast * style: remove WithWaitBlockDuration option In favor of a parameter in WaitForBlockHeight * oups * use black box testing only Co-authored-by: Lucas Btd <lucas.bertrand.22@gmail.com> Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
Since we are forcing the updage of changelog.md on every PR, this leads to many conflicts when it's time to merge. By forcing the merge strategy of this file to `union`, it decreases the chance of conflicts by ~90%. The downside is sometimes the merge gets wrong (repeated lines) so the dev should have a look at the result.
* fix: use slashes for key separators * docs: prefixes Co-authored-by: Jerónimo Albi <jeronimo.albi@tendermint.com>
* test: cosmosclient.CreateTx * test: cosmosclient.BankBalances * style: import order Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
* Added WIP draft of the migration to Cosmos SDK v0.46 doc * Update dependencies * IBC module updates * Added a handler section * Update docs/docs/migration/v0.24.md Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> * Update docs/docs/migration/v0.24.md Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> * migration docs sidebar order Co-authored-by: Alex Johnson <alex@shmeeload.xyz> Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Fix #2817 There's 2 reasons why the change should be reverted: - the version that does the registration automatically is not released yet (0.24) - the hello tutorial requires the use of cli 0.22, where the registration is always manual. What could be changed in the 0.24 documentation: - remove the 0.22 requirement (latest could be used w/o any problem I think) - remove the manual grpc registration.
* feat(cosmosclient): more contextualized errors This mitigates the problem 1) listed in #2788. If the tendermint RPC client returns a JSON error, now it's prefixed properly with a label mentionning the node address. * fix: node q tx because of empty keyring backend * add test removed with TestNew * remove unecessary comments * add TODO about wrapper removal condition * Update ignite/cmd/node.go Co-authored-by: Alex Johnson <alex@shmeeload.xyz> * style: use pkg/errors Co-authored-by: Alex Johnson <alex@shmeeload.xyz>
…2142) (#2143) * feat(frontend): ts-client + pinia (#2142) * Update index.ts.tpl * Update index.ts.tpl * Update package.json.tpl * Update index.ts.tpl * Update package.json.tpl * Update generate_javascript.go * Create index.ts.tpl * Create module.ts.tpl * Create pinia.ts.tpl * Create idnex.ts.tpl * Rename idnex.ts.tpl to index.ts.tpl * Create package.json.tpl * Delete starport/pkg/cosmosgen/templates/vuex directory * Delete starport/pkg/cosmosgen/templates/js directory * Update cosmosgen.go * Update generate_javascript.go * Update template.go * Update generate.go * Update generate.go * Update scaffolder.go * Rename generate_vuex.go to generate_sdk.go * Update config.go * Update generate_javascript.go * Update build.go * Update generate_sdk.go * Update generate_javascript.go * Update generate_javascript.go * 🏗 * adjusted pinia path * 🏗 * n * n * Update starport/pkg/cosmosgen/templates/root/index.ts.tpl Co-authored-by: Alex Megalokonomos <alex@clockwork.gr> * n * plugins * refactored * adjusted ts templates * mod tidy * better syntax * bump @ignt/plugins * tpl header * string formatting * adjusted test out dir * adjusted integration test * adjusted integration test * minors * Update docs/cli/index.md Co-authored-by: Barrie Byron <barriebyron@gmail.com> * Update ignite/cmd/generate_typescript_client.go Co-authored-by: Barrie Byron <barriebyron@gmail.com> * Update docs/kb/frontend.md Co-authored-by: Barrie Byron <barriebyron@gmail.com> * Update build.go * expand on the web app template * grammar fixes for the articles * mono repo URL is changed * add missing article for grammar fix * grammar fix and add more scope to the web app template * feat: Client config typing (#2569) * feat: Client config typing * fix: remove console * wip * wip * fix: remove accidentally committed files * fixed: type issues/code duplication * fix: use new @starport/vuex getter * fix: correct export * fix: changed generate typescript and vuex to match latest changes * fix: change output dir for typescript root templates * fix: remove "module" suffix from typescript module paths It seems that the module folder was replaced by the `module.ts` file during module generation. * fix: replace deprecated `strings.Title()` by a caser * fix: remove unused `monitoringProviderQuery` field from `Network` * ci: fix linting issues * chore: fix issue with vuex generation * chore: fix vuex module path issue * test: fix broken `cosmosgen` test * fix: correct client root path * test: fix broken integration test * refactor: remove namespace prefix from module paths * ci: fix invalid `Join` call * docs: fixed TS client directory name * test: fix broken unit test * refactor: add link to ts-client to vue app dependencies during scaffold * chore: add indentation to the packages.json file * fix: change Vuex generation to use a relative ts-client link path * chore: change vue app dependency update to return custom errors * fix: Template version and fee fixes * fix: Bump template. Correct proto case types * fix: change TS client generation to always generate third party modules This change is required to re-generate the root module; This module imports and registers custom and third party modules so disabling the 3rd party ones would cause that the pre generated modules wouldn't be imported and registered by the root template. * fix: remove unnecessary env vars * fix: Change generate command from `typescript` to `ts-client` * fix: expose individual clients * fix: add global signingClient * Update ignite/pkg/cosmosgen/templates/root/client.ts.tpl Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> * docs: Ts client information * fix: Correct docs markup * fix: add ts syntax to docs code * fix(docs): break up one-liners * fix(docs): Add plugin usage * docs and fixes Co-authored-by: Alex Megalokonomos <alex@clockwork.gr> Co-authored-by: Barrie Byron <barriebyron@gmail.com> Co-authored-by: barriebyron <> Co-authored-by: jeronimoalbi <jeronimo.albi@tendermint.com> Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> Co-authored-by: İlker G. Öztürk <ilkergoktugozturk@gmail.com>
Co-authored-by: ilgooz <ilgooz@users.noreply.github.com>
Co-authored-by: ilgooz <ilgooz@users.noreply.github.com>
* update go mod * clock package * refactor network * new cmd * last changes * typoe * import * fix unit test * fix test 2 * Upgrade for send request * publish: add balance * new logic for adding accounts * format * change switch * changelog * Update ignite/cmd/network_chain_join.go Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> Co-authored-by: Alex Johnson <alex@shmeeload.xyz> Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
ilgooz
requested review from
lumtis,
jeronimoalbi,
aljo242 and
tbruyelle
as code owners
September 12, 2022 14:01
Visit the preview URL for this PR (updated for commit 5ad53f5): https://ignite-go-docs--pr2826-develop-rpmq693z.web.app (expires Mon, 19 Sep 2022 14:13:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
wahzhi
approved these changes
Oct 1, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
chore: release v0.24.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.