Skip to content

feat: new argument for incident() #2178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

feat: new argument for incident() #2178

merged 1 commit into from
Oct 2, 2025
+60 −11

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Sep 30, 2025

No description provided.

@maelle maelle requested a review from schochastics September 30, 2025 10:51
@maelle
Copy link
Contributor Author

maelle commented Sep 30, 2025

the error I was getting (now gone) made me notice we were not using incident_impl() but maybe there's a reason.

@maelle
Copy link
Contributor Author

maelle commented Sep 30, 2025

#2100

@maelle maelle closed this Sep 30, 2025
@krlmlr krlmlr reopened this Oct 2, 2025
@krlmlr krlmlr marked this pull request as ready for review October 2, 2025 08:46
@krlmlr krlmlr merged commit a7800fd into b-next Oct 2, 2025
@krlmlr krlmlr deleted the incident-incident branch October 2, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schochastics schochastics Awaiting requested review from schochastics

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maelle @krlmlr