Remove cram data uri check #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, thanks for the PR. This has evolved over the years, originally the data URI was expanded in place and indexes were ignored, it gradually became more consistent with "regular" URIs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous comment it was mentioned that data URIs don't work for the cram format. Data URIs seem to work just fine for the cram format when removing the check that disables it, see the provided test case. You must provide an indexURI (which can also be a data URI), but I guess that is always the case for cram alignment tracks?
This makes sense since the underlying code in igv-utils handles data retrieval for both data URIs and other URIs.
We're currently using embedded bams in offline html files and would be really happy if we could switch to cram to reduce file size.