Guess Fasta indexURL
from functions as well
#1821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you again for an awesome project!
I found one bug. It's not exactly a bug, since it only occurs if you disobey the documentation. Documentation doesn't mention this, but I found that - thanks to
igvxhr
- I can provide async functions for any URL in the config. However, if I setfastaURL
as a function and omitindexURL
andindexFile
, IGV.js generates a(function() {}).fai
gibberish URL.I understand this isn't a typical bug because the documentation doesn't mention using functions for
fastaURL
. And, I know you wanted to reconsider the whole idea of guessing that URL. However, I wanted to fix this for consistency with track URLs and to add tests, so if you decide to change this behavior, it's test covered.Feel free to request changes to this PR.