Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess Fasta indexURL from functions as well #1821

Merged
merged 1 commit into from
May 24, 2024

Conversation

fiskus
Copy link
Contributor

@fiskus fiskus commented May 23, 2024

Hi! Thank you again for an awesome project!

I found one bug. It's not exactly a bug, since it only occurs if you disobey the documentation. Documentation doesn't mention this, but I found that - thanks to igvxhr - I can provide async functions for any URL in the config. However, if I set fastaURL as a function and omit indexURL and indexFile, IGV.js generates a (function() {}).fai gibberish URL.

I understand this isn't a typical bug because the documentation doesn't mention using functions for fastaURL. And, I know you wanted to reconsider the whole idea of guessing that URL. However, I wanted to fix this for consistency with track URLs and to add tests, so if you decide to change this behavior, it's test covered.

Feel free to request changes to this PR.

@jrobinso
Copy link
Contributor

jrobinso commented May 24, 2024

Yes, this looks safe as it only comes into play if indexURL is not specified. I would like to make indexURL required, but am hesitating as igv.js has been out for a long time and has many installations. Hopefully no one is counting on this guessing behavior, but the very need for this PR argues that some are.

Thanks again for the PR, and especially for including tests.

@jrobinso jrobinso merged commit d46a666 into igvteam:master May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants