Fix castle dialog rendering bugs #7960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ihhub
approved these changes
Oct 19, 2023
Branikolog
approved these changes
Oct 20, 2023
|
@Districh-ru , huge thanks for these changes! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7913, fixes #6971 and also fixes incorrect hero recruitment (fade-in) animation when a hero is recruited after the castle was changed in the construction dialog:
Master build:
fheroes2.2023-10-18.18-01-31-221.mp4
This PR:
fheroes2.2023-10-18.18-06-44-978.mp4
Some minor code lean-up is also made in this PR along with adding the right mouse button press tips for OKAY and CANCEL buttons in Recruit Hero dialog and Build dialog:
And adds captain image fade-in animation:
fheroes2.2023-10-18.18-10-10-320.mp4