Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find thumbnail [a.k.a. cover/poster. For MP4; not just WebM] #65

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

deldesir
Copy link
Collaborator

This is a fix for the missing cover bug when an 'mp4' video file is downloaded. Smoke and feature tested on Ubuntu 24.04 (10.8.0.18).

@deldesir deldesir added the bug Something isn't working label Dec 18, 2023
@deldesir deldesir requested a review from holta December 18, 2023 11:59
@deldesir deldesir self-assigned this Dec 18, 2023
@holta
Copy link
Member

holta commented Dec 18, 2023

@holta holta merged commit 3e1903a into iiab:master Dec 18, 2023
@holta holta changed the title Find thumbnail Find thumbnail [a.k.a. cover/poster. For MP4; not just WebM] Dec 18, 2023
@holta
Copy link
Member

holta commented Dec 18, 2023

Screenshot 2023-12-18 114636

Looks far better!!

A separate bug is the description(s) full text/paragraphs now appear missing — see the screenshot above — apparently due to an upstream change or regression in xklb ?

root@box:~# yt-dlp --version
2023.11.16
root@box:~# lb --version
2.2.186
root@box:~# hostname -I
10.181.233.245 192.168.0.117 10.8.0.46 fd42:fb6b:9c93:d2f1:5054:ff:fe1b:116f
root@box:~# hostname -A
t4.lxd box box t4.lxd
root@box:~# cat /etc/issue
Ubuntu Noble Numbat (development branch) \n \l```

@holta
Copy link
Member

holta commented Dec 19, 2023

image

@deldesir can you explain why cover/poster/thumbnail is missing after downloading... ?

root@box:~# yt-dlp --version
2023.11.16
root@box:~# lb --version
2.2.189
root@box:~# hostname -I
10.181.233.245 192.168.0.117 10.8.0.46 fd42:fb6b:9c93:d2f1:5054:ff:fe1b:116f
root@box:~# hostname -A
t4.lxd box box t4.lxd
root@box:~# cat /etc/issue
Ubuntu Noble Numbat (development branch) \n \l

@deldesir
Copy link
Collaborator Author

Thanks @holta for catching this. The logic was a bit loose comparing files without taking extensions into consideration. Fixed in #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants