-
Notifications
You must be signed in to change notification settings - Fork 48
Implement DIGSY scenarios part2 #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use .model.workflow.step_0 (#354) instead of .engage.workflow.step_0. - In .project.navigate.tax_emission, use add_tax_emission from within message_ix_models instead of from message_data.
- Use metaclass to construct an Enum subtype for e.g. SSP_2024. - Update tests. - Import the name EnumMeta for Python ≤3.10 compatibility.
This change avoids sporadic local mypy failures via pre-commit.
- Exported from a variety of current scenarios with "_v5.3.1_" in the model name. - Omit scenarios without at least one of: - Values for all regions. - A time series of values covering at least half of the model horizon.
- Update test expectations.
- Add tests.
- Collect per-instance options; separate these from class attributes. - Separate .exo_data.add_structure(). - Move core logic from prepare_computer() to ExoDataSource.add_tasks(). - Rename ExoDataSource.__call__() → .get(). - Warn of deprecation in prepare_computer(). - Expand and improve docs, docstrings, type hints.
- Simplify docstrings. - Drop use of ExoDataSource.raise_on_extra_kw(). - Test both old and new methods of adding tasks.
- Add self-documenting Options classes. - Use consistent type hints. - Drop redundant attributes, methods. - Add a common base class for SSP{Original,Update}.
- Rename test_prepare_computer → test_add_tasks. - Use .add_tasks() in test. - Add type hints. - Adjust xfail marks.
Use TQuantity where appropriate.
- Load from the local data path/message-static-data. - Recompress using xz compression to match message-static-data. - Adjust fuzzed test data and tests to match.
- Adjust test marks.
Tune based on values for scale-1 in .transport.base.
…in .model.material.data_util, .tools.costs.gdp. Also: - Fix release 3.1 of the SSPUpdate data, in both places. - Flatten nested loops using itertools.product().
- Deprecated since 2023-11 / superseded by .project.advance.data. - No longer used within message_ix_models.
- Check whether a successfully loaded, existing scenario has the expected nodes; if not, discard and re-create. - Align code, log messages, type hints of bare_res() and built_transport(). - Remove explicit CI-/OS-specific XFAIL in build_transport().
pdt per cap per mode by DIGSY scenarios
elasticity-f values for digsy-base, digsy-best & digsy-worst scenarios
Temporary setup, in order to run DIGSY scenarios
fixing the bug to run DIGSY scenarios
LED settings are the same as SSP2 in this case
Elasticity-f values for LED are updated to DIGSY scenario
These are not the actual LED value, rather they correspond to SSP2 PDT values. The idea here is to check if we get the same results using this exogenous pdt-cap setup as in normal SSP2 setup
the updated pdt-cap file reflect the DIGSY best case scenario
the values for LED elsticity-f in this file reflect the DiGSY best case scenario
The values under the LED label here reflect the DIGSY worst case scenario for frieght demand
The values under the LED label here reflect the DIGSY worst case scenario for passenger travel
For MCE EDITS we use SSP2 f-elasticity values
These are experimental values, combining PASTA & MixT PDT values, that were set up by Tao/Masa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to run the DIGSY scenario using the old adhoc setup, until the full setup is ready
How to review
Make sure these changes are not included in the main branch eventually. The main branch should be merged with w-32 branch
PR checklist
Continuous integration checks all ✅