Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate #321

Merged
merged 12 commits into from
Apr 13, 2024
Merged

Release candidate #321

merged 12 commits into from
Apr 13, 2024

Conversation

ikawaha
Copy link
Owner

@ikawaha ikawaha commented Apr 10, 2024

No description provided.

@KEINOS
Copy link
Contributor

KEINOS commented Apr 12, 2024

It seems that you need to merge this PR to v2 branch first before running the "release" action.

Looking at the below failed action log of "release";

https://github.com/ikawaha/kagome/actions/runs/8630665114/job/23657420113#step:8:23

Both DockerHub and GHC login are success. And reading the mapped GITHUB_TOKEN as well.
So far so good.

But when getting and validating git state step, it is comparing the "develop" branch.
Which doesn't have the version tag info. Such as v2.9.5. "v2" branch has, tho.

Due to matching the version of the binary name/image tag and the source, goreleaser requires to match the commit ID of tagged version, and the current source commit ID.

Thus, you need to:

  1. Merge this PR to v2
  2. Tag a new version v2.9.6-beta or v2.9.6 and push the tag
  3. Create a new release

We are so close to close #319! 🤞

@ikawaha ikawaha changed the title Develop: Release candidate Release candidate Apr 13, 2024
@ikawaha ikawaha merged commit f70560c into v2 Apr 13, 2024
7 checks passed
@ikawaha ikawaha deleted the develop branch April 13, 2024 12:30
@ikawaha ikawaha restored the develop branch April 20, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants