More workflow refactoring #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
emilmelnikov
commented
Aug 11, 2023
emilmelnikov
commented
- Extract subprocess running logic into Subprocess
- TempDir is now a separate class
- Extract Spinner into more general StatusBar
- Merge WorkflowCommand core logic into a single method
emilmelnikov
force-pushed
the
more-workflow-refactoring
branch
from
f956f8c
to
e30f4a0
Compare
* Extract subprocess running logic into Subprocess * TempDir is now a separate class * Extract Spinner into more general StatusBar * Merge WorkflowCommand core logic into a single method
emilmelnikov
force-pushed
the
more-workflow-refactoring
branch
from
e30f4a0
to
797a967
Compare
k-dominik
approved these changes
Aug 14, 2023
emilmelnikov
added a commit
that referenced
this pull request
Aug 16, 2023
This fixes bug introduced in #111.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.