-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isar-bootstrap.inc::get_distro_primary_source_entry() should not return ["", "", ""] by default #72
Comments
Hello Henning, we'd like to understand the context, can you provide the steps to reproduce? If you also have a suggestion in form of a patch, feel free to share. |
I guess the way to repro would be to use an "invalid" i.e. empty sources.list If that happens we indeed could probably detect that early instead of returing something that will just break in a weird way further down the line. Maybe return None, None, None or simply raise/bbfatal |
@henning-schild I would highly appreciate that. In my case, the list was not empty. However, I made a typo in the distro name. Thus, nothing was read from the list. It took me a long time to figure out the root cause. I think throwing an error in this function at isar layer would massively ease debugging. |
In this case i am afraid the example file would be indeed needed. Because you maybe did not even run into the |
Just have proposed the patch at |
@amikan Thanks. I will try it and let you know. |
Returning empty list leads to ambiguous errors, so we should fail early if distro sources.list is empty or incorrect. Fix issue #72 Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
Returning empty list leads to ambiguous errors, so we should fail early if distro sources.list is empty or incorrect. Fix issue #72 Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
Returning empty list leads to ambiguous errors, so we should fail early if distro sources.list is empty or incorrect. Fix #72 Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
Returning empty list leads to ambiguous errors, so we should fail early if distro sources.list is empty or incorrect. Fix #72 Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
Returning empty list leads to ambiguous errors, so we should fail early if distro sources.list is empty or incorrect. Fix ilbers#72 Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
From my point of view, this function:
https://github.com/ilbers/isar/blob/master/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc#L165
should not return ["", "", ""] by default. Instead, is should throw an error.
The rational is as follows: returning ["", "", ""] leads to ambiguous errors, if, e.g.,:
The text was updated successfully, but these errors were encountered: