25 refactoring data generation script #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 7, 2022 18:40
Refractoring of data moved, fixed the Regex for parsing the lines, created methods for the AwesomeEvent class
|
thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i'm a newbie on github, this is my first pull-request,
i'd like to make my contribution:
As requested from the issue issues-25, i tried to refractor to lots of different files, but in my opinion the only thing worth moving from the main file, was the parsing of the string, since it's the most verbose code to understand.
I re-used lots of code that was arleady written, and i tried to make some tweakes.
The regex that was used, had some issues of matching, so i changed it, and it fixes some old events generated, where the location had some pieces of the description in it.
I tried the Python script with python 3.9 and locally in my pc, but i think it's going to work just fine the Github action system.
Hopeful that you can accept my request. I'm here for any questions