Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul XMLUI Discovery config #186

Closed
alanorth opened this issue Mar 11, 2016 · 1 comment
Closed

Overhaul XMLUI Discovery config #186

alanorth opened this issue Mar 11, 2016 · 1 comment
Assignees
@alanorth
Labels
enhancement xmlui
Milestone
2016-03

Comments

@alanorth
Copy link
Member

During investigations for #180, #185, and #132 I realized that our Discovery configuration is messy and confusing as hell—I'm surprised it works at all! For starters:

  • Custom strings are defined in the wrong messages.xml file:
    • They are in: dspace-xmlui/src/main/resources/aspects/Discovery/i18n/messages.xml
    • Instead of: dspace/modules/xmlui/src/main/webapp/i18n/messages.xml
  • We should use singular sentence case for Discovery "view more" pages
  • "Filter by: Biodiversity subjects" in dspace-xmlui/src/main/resources/aspects/Discovery/i18n/messages.xml
@alanorth alanorth self-assigned this Mar 11, 2016
@alanorth alanorth added this to the 2016-03 milestone Mar 11, 2016
@alanorth
Copy link
Member Author

Fixed in #190.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanorth alanorth

Labels
enhancement xmlui
Projects
None yet
Milestone
2016-03
Development

No branches or pull requests
1 participant
@alanorth