Font Awesome improvements #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're loading Font Awesome anyways for the sharing icons, so we might as well save one network request by printing the icon instead of requesting the PNG.
Protocol-relative links are an anti pattern in 2016. If a resource is available over HTTPS you should fetch it over HTTPS.
For accessibility we should notify screenreaders that these icons are only for visual cues.
|
Replace more images with font icons and adjust their color/style so nobody will notice...
That's three less network requests that we have to make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're already loading Font Awesome for the sharing icons, so we should use it in more places to save network requests. Also, it's good to give a cue to screen readers that the icons are for visual purposes only.